From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5C5EC1FF170 for ; Thu, 7 Aug 2025 16:22:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F113F31068; Thu, 7 Aug 2025 16:24:02 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 07 Aug 2025 16:23:29 +0200 To: "Fiona Ebner" , "Proxmox VE development discussion" Message-Id: X-Mailer: aerc 0.20.0 References: <20250806134843.266183-1-s.sterz@proxmox.com> <106f30b8-9a89-4d0c-b45e-0cd8259344ea@proxmox.com> In-Reply-To: <106f30b8-9a89-4d0c-b45e-0cd8259344ea@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754576586354 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.127 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] Superseded: [PATCH manager] 8 to 9: use more robust systemd version parsing regex from pve-container X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Thu Aug 7, 2025 at 2:56 PM CEST, Fiona Ebner wrote: > Am 06.08.25 um 3:49 PM schrieb Shannon Sterz: >> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm >> index 994189f13..a7ee842de 100644 >> --- a/PVE/CLI/pve8to9.pm >> +++ b/PVE/CLI/pve8to9.pm >> @@ -1282,7 +1282,8 @@ sub check_containers_cgroup_compat { >> last if defined($libsd); >> } >> if ( >> - defined($libsd) && $libsd =~ /libsystemd-shared-(\d+)(\.\d-\d)?(\.fc\d\d)?\.so/ >> + defined($libsd) >> + && $libsd =~ /libsystemd-shared-(\d+)(?:[-.][a-zA-Z0-9]+)*\.so:?$/ > > I guess the colon at the very end is there, because in pve-container we > check via objdump rather than checking paths? It's already optional so > wouldn't be a functional change, but wanted to make sure. > Since we already use > > my $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir); > > below, can't we simply call > > $lxc_setup->unified_cgroupv2_support() > > directly like we do in the prestart hook? yep makes sense, i'll look into that, but was a bit worried about bigger changes to this code. i send a v2 with these changes, so consider this: Superseded-by: https://lore.proxmox.com/pve-devel/20250807142246.341381-1-s.sterz@proxmox.com/T/#u _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel