From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E42261FF183 for ; Wed, 30 Jul 2025 19:27:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D4CC15C79; Wed, 30 Jul 2025 19:29:22 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 30 Jul 2025 19:29:19 +0200 Message-Id: From: "Max R. Carrara" To: "Proxmox VE development discussion" X-Mailer: aerc 0.18.2-0-ge037c095a049 References: <20250730162117.160498-1-f.ebner@proxmox.com> In-Reply-To: <20250730162117.160498-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753896548477 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lvmplugin.pm] Subject: Re: [pve-devel] [PATCH-SERIES storage 0/3] fix #6587: lvm plugin: snapshot info: fix parsing snapshot name X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Wed Jul 30, 2025 at 6:20 PM CEST, Fiona Ebner wrote: > Volume names are allowed to contain underscores, so it is impossible > to determine the snapshot name from just the volume name, e.g: > snap_vm-100-disk_with_underscore_here_s_some_more.qcow2 > > Therefore, we need to also rely on the volume name itself to properly > parse the snapshot name. Did some testing and tried to break things. Works as advertised and even fixes previously broken snapshots--that is, if one tried to delete a snapshot on LVM before this patch, the snapshot would become stuck in the "deleted" state. Once this patch was applied, I was able to delete the stuck snapshot as well (after `qm unlock`, naturally). The changes also seem fine to me; gave patch 02 most of my attention since that's where the fix is. Couldn't spot anything wrong with any of the changes here. So, LGTM -- consider: Tested-by: Max R. Carrara Reviewed-by: Max R. Carrara > > Fiona Ebner (3): > lvm plugin: snapshot info: avoid superfluous argument for closure > fix #6587: lvm plugin: snapshot info: fix parsing snapshot name > lvm plugin: volume snapshot: actually print error when renaming > > src/PVE/Storage/LVMPlugin.pm | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel