From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C64F81FF183 for ; Wed, 30 Jul 2025 15:59:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5AE45100E0; Wed, 30 Jul 2025 16:00:58 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 30 Jul 2025 16:00:26 +0200 Message-Id: From: "Lukas Wagner" To: "Proxmox Backup Server development discussion" , "Christian Ebner" X-Mailer: aerc 0.20.1-0-g2ecb8770224a References: <20250728064645.158414-1-c.ebner@proxmox.com> In-Reply-To: <20250728064645.158414-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753884015396 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} 00/10] s3: implement list buckets and use bucket selector for datastore creation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On Mon Jul 28, 2025 at 8:46 AM CEST, Christian Ebner wrote: > This patches aim to increase usability for the user by allowing to list > accessible buckets during datastore creation. > > For this, the proxmox s3 client is extended by the list buckets method, fetching > accessible buckets from the s3 api. This requires the client instantiation to be > possible without the bucket name, making it therefore optional. Further, the > regex for the config endpoint url must be restricted to have the bucket name > template pattern always at the start of the template. With these changes, it is > then possible to fetch the buckets given the required permissions to do so. > > On the proxmox backup server side, the api endpoints to fetch the bucket list > are implemented as well as the corresponding cli command. Finally, the bucket > name field in the datastore edit window is replaced by an s3 bucket selector, > which loads the accessible bucket names via the api. > Apart from the issue I mentioned in my other mail, this looks good to me: Reviewed-by: Lukas Wagner _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel