From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D58561FF183 for ; Wed, 30 Jul 2025 14:47:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 96149D219; Wed, 30 Jul 2025 14:49:10 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 30 Jul 2025 14:49:08 +0200 Message-Id: To: "Proxmox VE development discussion" , "Maximiliano Sandoval" X-Mailer: aerc 0.20.0 References: <20250730103825.233570-1-m.sandoval@proxmox.com> <20250730103825.233570-3-m.sandoval@proxmox.com> In-Reply-To: <20250730103825.233570-3-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753879737570 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2 2/3] improve some translatable strings X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote: > In certain languages (e.g. spanish) CT and VM would have different > genders, hence it is not possible to use the same string. > > Signed-off-by: Maximiliano Sandoval > --- > www/manager6/dc/MetricServerView.js | 2 +- > www/manager6/window/Restore.js | 11 +++++------ > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/www/manager6/dc/MetricServerView.js b/www/manager6/dc/MetricServerView.js > index 26e89923..683e91fd 100644 > --- a/www/manager6/dc/MetricServerView.js > +++ b/www/manager6/dc/MetricServerView.js > @@ -369,7 +369,7 @@ Ext.define('PVE.dc.InfluxDBEdit', { > { > xtype: 'proxmoxintegerfield', > name: 'max-body-size', > - fieldLabel: gettext('Batch Size (b)'), > + fieldLabel: gettext('Batch Size (bits)'), nit: this is unrelated to the reasoning above, might be nice to add some information about this too and/or split it out > minValue: 1, > emptyText: '25000000', > submitEmpty: false, > diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js > index 690116df..7fb0167b 100644 > --- a/www/manager6/window/Restore.js > +++ b/www/manager6/window/Restore.js > @@ -93,13 +93,12 @@ Ext.define('PVE.window.Restore', { > }; > > if (view.vmid) { > - confirmMsg += `. ${Ext.String.format( > - gettext('This will permanently erase current {0} data.'), > - view.vmtype === 'lxc' ? 'CT' : 'VM', > - )}`; > - if (view.vmtype === 'lxc') { > + if (view.vmtype === 'lxc') > + confirmMsg += `. ${gettext('This will permanently erase current CT data.')}`; > confirmMsg += `
${gettext('Mount point volumes are also erased.')}`; > - } > + } else { > + confirmMsg += `. ${gettext('This will permanently erase current VM data.')}`; > + }; > Ext.Msg.confirm(gettext('Confirm'), confirmMsg, function (btn) { > if (btn === 'yes') { > executeRestore(); _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel