From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3A87A1FF183 for ; Wed, 30 Jul 2025 14:47:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4683AD123; Wed, 30 Jul 2025 14:48:35 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 30 Jul 2025 14:48:31 +0200 Message-Id: To: "Proxmox VE development discussion" , "Maximiliano Sandoval" X-Mailer: aerc 0.20.0 References: <20250730103825.233570-1-m.sandoval@proxmox.com> <20250730103825.233570-10-m.sandoval@proxmox.com> In-Reply-To: <20250730103825.233570-10-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753879701134 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH backup v2 1/3] add translators comments to some translations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote: > These will be displayed in translator editors and provide context for > translators. > > Signed-off-by: Maximiliano Sandoval > --- > www/tape/DriveStatus.js | 1 + > www/window/DataStoreEdit.js | 1 + > www/window/S3ClientEdit.js | 2 ++ > 3 files changed, 4 insertions(+) > > diff --git a/www/tape/DriveStatus.js b/www/tape/DriveStatus.js > index 881bc1fdd..4405e4380 100644 > --- a/www/tape/DriveStatus.js > +++ b/www/tape/DriveStatus.js > @@ -335,6 +335,7 @@ Ext.define('PBS.TapeManagement.DriveStatusGrid', { > if (!value) { > return gettext('Dynamic'); > } > + // TRANSLATORS: As in "fixed block size" > return `${gettext('Fixed')} - ${Proxmox.Utils.format_size(value)}`; > }, > }, > diff --git a/www/window/DataStoreEdit.js b/www/window/DataStoreEdit.js > index b414bd4c0..e12fea09f 100644 > --- a/www/window/DataStoreEdit.js > +++ b/www/window/DataStoreEdit.js > @@ -229,6 +229,7 @@ Ext.define('PBS.DataStoreEdit', { > }, > }, > { > + // TRANSLATORS: As in "options of the prune operation" > title: gettext('Prune Options'), > xtype: 'pbsPruneInputPanel', > cbind: { > diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js > index f0a5efba8..ca70dbbb2 100644 > --- a/www/window/S3ClientEdit.js > +++ b/www/window/S3ClientEdit.js > @@ -57,6 +57,7 @@ Ext.define('PBS.window.S3ClientEdit', { > xtype: 'proxmoxtextfield', > name: 'port', > fieldLabel: gettext('Port'), > + // TRANSLATORS: this is a port number > emptyText: gettext('default (443)'), > cbind: { > deleteEmpty: '{!isCreate}', > @@ -80,6 +81,7 @@ Ext.define('PBS.window.S3ClientEdit', { > xtype: 'proxmoxtextfield', > name: 'region', > fieldLabel: gettext('Region'), > + // TRANSLATORS: this is a region code nit: your indentation seems to use tabs here and spaces otherwise? also i'd prefer something like "this is an S3 region code" just to clarify this a bit further (region codes can be many things imo and you don't necessarily have the context that this is relevant for the s3 datastores here) > emptyText: gettext('default (us-west-1)'), > cbind: { > deleteEmpty: '{!isCreate}', _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel