From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 770CC1FF183 for ; Wed, 30 Jul 2025 14:47:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7C93BD152; Wed, 30 Jul 2025 14:49:00 +0200 (CEST) Mime-Version: 1.0 Date: Wed, 30 Jul 2025 14:48:27 +0200 Message-Id: Cc: "pve-devel" To: "Proxmox VE development discussion" X-Mailer: aerc 0.20.0 References: <20250730103825.233570-1-m.sandoval@proxmox.com> <20250730103825.233570-6-m.sandoval@proxmox.com> In-Reply-To: <20250730103825.233570-6-m.sandoval@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753879696740 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit v2 2/3] add context to translatable strings X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote: > Signed-off-by: Maximiliano Sandoval > --- > src/Utils.js | 2 ++ > src/panel/NotificationConfigView.js | 1 + > src/window/ZFSDetail.js | 1 + > 3 files changed, 4 insertions(+) > > diff --git a/src/Utils.js b/src/Utils.js > index 92cbf28..27fb69c 100644 > --- a/src/Utils.js > +++ b/src/Utils.js > @@ -786,6 +786,7 @@ Ext.define('Proxmox.Utils', { > > format_size: function (size, useSI) { > let unitsSI = [ > + // TRANSLATORS: This the Bytes unit (e.g. 1B = 8 bits) nit: this (and the same occurance below) are missing an "is", "This is the Bytes unit [..]" > gettext('B'), > gettext('KB'), > gettext('MB'), > @@ -797,6 +798,7 @@ Ext.define('Proxmox.Utils', { > gettext('YB'), > ]; > let unitsIEC = [ > + // TRANSLATORS: This the Bytes unit (e.g. 1B = 8 bits) > gettext('B'), > gettext('KiB'), > gettext('MiB'), > diff --git a/src/panel/NotificationConfigView.js b/src/panel/NotificationConfigView.js > index 92e1f9b..85e45a0 100644 > --- a/src/panel/NotificationConfigView.js > +++ b/src/panel/NotificationConfigView.js > @@ -163,6 +163,7 @@ Ext.define('Proxmox.panel.NotificationEndpointView', { > }, > { > dataIndex: 'name', > + // TRANSLATORS: As in "the target's name" > text: gettext('Target Name'), > renderer: Ext.String.htmlEncode, > flex: 2, > diff --git a/src/window/ZFSDetail.js b/src/window/ZFSDetail.js > index 1c63b5a..2617b87 100644 > --- a/src/window/ZFSDetail.js > +++ b/src/window/ZFSDetail.js > @@ -83,6 +83,7 @@ Ext.define('Proxmox.window.ZFSDetail', { > renderer: Proxmox.Utils.render_zfs_health, > }, > scan: { > + // TRANSLATORS: This is a noun > header: gettext('Scan'), > }, > status: { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel