From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yew-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id A2CA51FF187
for <inbox@lore.proxmox.com>; Wed, 7 May 2025 10:16:02 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 3172235F9F;
Wed, 7 May 2025 10:16:20 +0200 (CEST)
Mime-Version: 1.0
Date: Wed, 07 May 2025 10:15:46 +0200
Message-Id: <D9PS2B3I565C.3JIQI14XCATTR@proxmox.com>
To: "Yew framework devel list at Proxmox" <yew-devel@lists.proxmox.com>,
"Dominik Csapak" <d.csapak@proxmox.com>
X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty
References: <20250506132633.2898717-1-d.csapak@proxmox.com>
<20250506132633.2898717-3-d.csapak@proxmox.com>
In-Reply-To: <20250506132633.2898717-3-d.csapak@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.019 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [yew-devel] [PATCH yew-comp 3/4] wizard: optimize enbaled check
for next button
X-BeenThere: yew-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Yew framework devel list at Proxmox <yew-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/yew-devel/>
List-Post: <mailto:yew-devel@lists.proxmox.com>
List-Help: <mailto:yew-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel>,
<mailto:yew-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: yew-devel-bounces@lists.proxmox.com
Sender: "yew-devel" <yew-devel-bounces@lists.proxmox.com>
On Tue May 6, 2025 at 3:26 PM CEST, Dominik Csapak wrote:
> by first checking for `self.loading` since we don't have to iterate
> over the wizard pages if that is true.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/wizard.rs | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/wizard.rs b/src/wizard.rs
> index e33d3c6..16b1dd8 100644
> --- a/src/wizard.rs
> +++ b/src/wizard.rs
> @@ -635,11 +635,11 @@ impl PwtWizard {
> Some(key) => props.pages.get_index_of(key).unwrap_or(0),
> };
>
> - let mut next_is_enabled = state.can_progress();
> -
> - if self.loading {
> - next_is_enabled = false;
> - }
> + let next_is_enabled = if self.loading {
> + false
> + } else {
> + state.can_progress()
> + };
couldn't this be more simply:
let next_is_enabled = !self.loading && state.can_progress();
i think that reads a bit more easily ("state isn't `loading` and we can
progress").
>
> let next_page = props
> .pages
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel