From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH dart_api_client 1/1] change exception toString to only print details if not null
Date: Mon, 05 May 2025 17:44:08 +0200 [thread overview]
Message-ID: <D9OCCI9R3X9X.1TGVJHZVIA6UN@noor> (raw)
In-Reply-To: <20250505072845.28299-1-m.koeppl@proxmox.com>
On Mon May 5, 2025 at 9:28 AM CEST, Michael Köppl wrote:
> Without this check, the toString method returns '-> null' at the end of
> the exception message if there are no details.
>
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
The change looks good to me. Please consider this change.
Reviewed-By: Shan Shaji <s.shaji@proxmox.com>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-05 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 7:28 Michael Köppl
2025-05-05 15:44 ` Shan Shaji [this message]
2025-05-21 11:04 ` Dominik Csapak
2025-05-23 7:51 ` Michael Köppl
2025-06-04 11:11 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9OCCI9R3X9X.1TGVJHZVIA6UN@noor \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.