From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id BBC181FF16F
	for <inbox@lore.proxmox.com>; Fri, 29 Nov 2024 11:55:35 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 0643316CB0;
	Fri, 29 Nov 2024 11:55:38 +0100 (CET)
Mime-Version: 1.0
Date: Fri, 29 Nov 2024 11:55:35 +0100
Message-Id: <D5YLW1K5IJVM.2M0OPS2TRG2AR@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>, "Proxmox VE development
 discussion" <pve-devel@lists.proxmox.com>, "Lukas Wagner"
 <l.wagner@proxmox.com>
X-Mailer: aerc 0.18.2-0-ge037c095a049-dirty
References: <20240624123134.321417-1-l.wagner@proxmox.com>
 <f1ba72e8-b86e-4450-869a-cd56e5a631fb@proxmox.com>
 <0c825d39-69cc-49ce-a078-647818f6cc5a@proxmox.com>
 <D5W058GWP0AN.IGIBK9HFVYQP@proxmox.com>
 <6a0f2b99-eab2-49f1-ac04-b01cbb041b03@proxmox.com>
In-Reply-To: <6a0f2b99-eab2-49f1-ac04-b01cbb041b03@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.038 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] applied: [PATCH proxmox 1/6] notify: copy
 sendmail/forward fn's from proxmox_sys
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On Tue Nov 26, 2024 at 11:21 AM CET, Thomas Lamprecht wrote:
> Am 26.11.24 um 10:27 schrieb Shannon Sterz:
> > actually i needed to adapt this to add support for attachments, which
> > require reworking the multipart logic a bit too. i can factor that out
> > into it's own `proxmox-sendmail` crate or similar and make
> > `proxmox-notify`'s sendmail endpoint use that too. if that's desired, i
> > can send patches for that too.
>
> Yeah, that might be nice. While this probably won't have a very high reusability,
> it can be carved out nicely in a standalone crate, and it should also not be a
> (fast) moving target, so fine to have as separate crate IMO.

finally managed to send patches for this, see here [1].

[1]: https://lore.proxmox.com/pbs-devel/20241129105321.143877-1-s.sterz@proxmox.com/



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel