From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id C4CF61FF16E
for <inbox@lore.proxmox.com>; Mon, 29 Jul 2024 12:30:10 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 579661B0C4;
Mon, 29 Jul 2024 12:30:11 +0200 (CEST)
Mime-Version: 1.0
Date: Mon, 29 Jul 2024 12:29:36 +0200
Message-Id: <D31YB5CT343L.LE4PN65R3FZ4@proxmox.com>
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Theodor Fumics" <theodor.fumics@gmx.net>, <pve-devel@lists.proxmox.com>
X-Mailer: aerc 0.17.0-69-g65571b67d7d3-dirty
References: <20240729095314.108158-1-theodor.fumics@gmx.net>
In-Reply-To: <20240729095314.108158-1-theodor.fumics@gmx.net>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.048 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager] ui: pool: separate "Add Virtual
Machine" menu into distinct options
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On Mon Jul 29, 2024 at 11:53 AM CEST, Theodor Fumics wrote:
> Split the "Add Virtual Machine" menu into separate options
> for Virtual Machines and Containers to reduce confusion.
> This change follows feedback from a user in [1], who had difficulty
> finding the container option.
>
> [1] https://forum.proxmox.com/threads/how-to-add-containers-to-a-resource-pool.151946/
>
> Signed-off-by: Theodor Fumics <theodor.fumics@gmx.net>
> ---
> www/manager6/grid/PoolMembers.js | 25 +++++++++++++++----------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js
> index 75f20cab..417e5d3d 100644
> --- a/www/manager6/grid/PoolMembers.js
> +++ b/www/manager6/grid/PoolMembers.js
> @@ -1,4 +1,4 @@
> -Ext.define('PVE.pool.AddVM', {
> +Ext.define('PVE.pool.AddGuest', {
> extend: 'Proxmox.window.Edit',
>
> width: 640,
> @@ -37,7 +37,7 @@ Ext.define('PVE.pool.AddVM', {
> ],
> filters: [
> function(item) {
> - return (item.data.type === 'lxc' || item.data.type === 'qemu') &&item.data.pool !== me.pool;
> + return (me.type === 'qemu' ? item.data.type === 'qemu' : item.data.type === 'lxc') && item.data.pool !== me.pool;
nit: this line is too long, according to our style guide we don't allow
lines longer than 100 columns [1].
you could shorten this to:
return (me.type === item.data.type) && item.data.pool !== me.pool;
which is also a lot more readable imo
[1]: https://pve.proxmox.com/wiki/Javascript_Style_Guide
> },
> ],
> });
> @@ -84,15 +84,11 @@ Ext.define('PVE.pool.AddVM', {
> dataIndex: 'name',
> flex: 1,
> },
> - {
> - header: gettext('Type'),
> - dataIndex: 'type',
> - },
> ],
> });
>
> Ext.apply(me, {
> - subject: gettext('Virtual Machine'),
> + subject: gettext(me.type === 'qemu' ? 'Virtual Machine' : 'LXC Container'),
> items: [
> vmsField,
> vmGrid,
> @@ -228,16 +224,25 @@ Ext.define('PVE.grid.PoolMembers', {
> items: [
> {
> text: gettext('Virtual Machine'),
> - iconCls: 'pve-itype-icon-qemu',
> + iconCls: 'fa fa-fw fa-desktop',
> + handler: function() {
> + var win = Ext.create('PVE.pool.AddGuest', { pool: me.pool, type: 'qemu' });
> + win.on('destroy', reload);
> + win.show();
> + },
> + },
> + {
> + text: gettext('Container'),
> + iconCls: 'fa fa-fw fa-cube',
> handler: function() {
> - var win = Ext.create('PVE.pool.AddVM', { pool: me.pool });
> + var win = Ext.create('PVE.pool.AddGuest', { pool: me.pool, type: 'lxc' });
> win.on('destroy', reload);
> win.show();
> },
> },
> {
> text: gettext('Storage'),
> - iconCls: 'pve-itype-icon-storage',
> + iconCls: 'fa fa-fw fa-hdd-o',
> handler: function() {
> var win = Ext.create('PVE.pool.AddStorage', { pool: me.pool });
> win.on('destroy', reload);
> --
> 2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel