From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 2C1601FF38A
for <inbox@lore.proxmox.com>; Fri, 14 Jun 2024 10:38:26 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 41D8E9542;
Fri, 14 Jun 2024 10:38:26 +0200 (CEST)
Mime-Version: 1.0
Date: Fri, 14 Jun 2024 10:37:51 +0200
Message-Id: <D1ZLR2FQPYNC.3BFL6YTL6C8E1@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, "Proxmox VE development
discussion" <pve-devel@lists.proxmox.com>
From: "Max Carrara" <m.carrara@proxmox.com>
X-Mailer: aerc 0.17.0-72-g6a84f1331f1c
References: <20240524132209.703402-1-d.csapak@proxmox.com>
<20240524132209.703402-19-d.csapak@proxmox.com>
<D1Y5Y1NPPQ1K.281RBAIADUF97@proxmox.com>
<9a905a24-9350-4841-8ae3-a45f38508dd3@proxmox.com>
In-Reply-To: <9a905a24-9350-4841-8ae3-a45f38508dd3@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.035 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH manager v4 2/9] ui: guest import: add
ova-needs-extracting warning text
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On Thu Jun 13, 2024 at 12:39 PM CEST, Dominik Csapak wrote:
> On 6/12/24 18:02, Max Carrara wrote:
> > On Fri May 24, 2024 at 3:22 PM CEST, Dominik Csapak wrote:
> >> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> >> ---
> >> www/manager6/window/GuestImport.js | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
> >> index 4bedc211..76ba6dc8 100644
> >> --- a/www/manager6/window/GuestImport.js
> >> +++ b/www/manager6/window/GuestImport.js
> >> @@ -937,6 +937,7 @@ Ext.define('PVE.window.GuestImport', {
> >> gettext('EFI state cannot be imported, you may need to reconfigure the boot order (see {0})'),
> >> '<a href="https://pve.proxmox.com/wiki/OVMF/UEFI_Boot_Entries">OVMF/UEFI Boot Entries</a>',
> >> ),
> >> + 'ova-needs-extracting': gettext('Importing from an OVA requires extra space while extracting the contained disks into the import or selected storage.'),
> >
> > I'm assuming the string here needs to be in one line because of
> > `gettext`, right? If not, I'd prefer to break it up ;)
>
> yes, AFAIK we the gettext parsing script does not handle multiline calls at the moment
> we could probably check if there is a javascript syntax parsing library available
> in perl, or rewrite the script in some other language where such a thing exists,
> then it wouldn't be so brittle probably
>
> but it's not generally such a big issue that we would need to worry about it
Alright, thanks for the clarification! I agree that it can stay then.
>
> >
> >> };
> >> let message = warningsCatalogue[w.type];
> >> if (!w.type || !message) {
> >
> >
> >
> > _______________________________________________
> > pve-devel mailing list
> > pve-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> >
> >
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel