From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 518D21FF396 for <inbox@lore.proxmox.com>; Thu, 6 Jun 2024 10:06:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CCC018F9C; Thu, 6 Jun 2024 10:07:25 +0200 (CEST) Mime-Version: 1.0 Date: Thu, 06 Jun 2024 10:06:52 +0200 Message-Id: <D1SS2ZNCW9Y6.LHIRET7YTUL2@proxmox.com> From: "Max Carrara" <m.carrara@proxmox.com> To: "Lukas Wagner" <l.wagner@proxmox.com>, "Proxmox VE development discussion" <pve-devel@lists.proxmox.com> X-Mailer: aerc 0.17.0-72-g6a84f1331f1c References: <20240430152857.659326-1-m.carrara@proxmox.com> <f0582db3-64f2-4ddb-80c4-78df1085ee4c@proxmox.com> In-Reply-To: <f0582db3-64f2-4ddb-80c4-78df1085ee4c@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v1 pve-manager 0/8] Ceph Build Commit in UI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On Wed Jun 5, 2024 at 4:48 PM CEST, Lukas Wagner wrote: > > > On 2024-04-30 17:28, Max Carrara wrote: > > Ceph Build Commit in UI - Version 1 > > =================================== > > > > This series adds Ceph's build commit to the UI and lets the user know if > > a service is running an outdated build and therefore ought to be > > restarted. > > > > The build commit is now displayed next to the version for all Ceph > > services like so: > > > > 18.2.2 (abcd1234) > > > > Should a service run an outdated build, the new build commit is also > > displayed: > > > > 18.2.2 (abcd1234 -> 5678fedc) > > > > (Icons are omitted here). > > > > See the individual patches for more in-depth information. > > > > Additionally, some of the code was also cleaned up and refactored a > > little along the way. > > > > I'm not 100% sure if the design I've opted for here is the best, so it > > would be great to get some opinions on this. The OSD tree/list view > > especially can get a little noisy if there are a lot of outdated OSDs > > running. > > > > Neat, gave this a quick test and this seems to do what you describe in the cover letter. > > Some comments: > - The 'outdated OSD' view in the top-level status widget uses a different icon to > signal an outdated OSD than the version column in the OSD tree view - maybe it would make sense > to use the same icon here? > - The 'Detail' view for OSDs could also show the commit hash, right now it only shows e.g. 18.2.2 (reef) > > > With the nits from the review fixed: > > Tested-by: Lukas Wagner <l.wagner@proxmox.com> > Reviewed-by: Lukas Wagner <l.wagner@proxmox.com> Thanks a lot for the review and giving this a spin! I'll see if I can send in a v2 soon. If noone else has any objections, I'll attach your T-b and R-b tags in the new series. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel