From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id A47E920EC88
for <inbox@lore.proxmox.com>; Thu, 25 Apr 2024 10:37:39 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0838F1D276;
Thu, 25 Apr 2024 10:37:45 +0200 (CEST)
Mime-Version: 1.0
Date: Thu, 25 Apr 2024 10:37:10 +0200
Message-Id: <D0T2FAWKDPSX.YSZ83B6DKC62@proxmox.com>
From: "Stefan Sterz" <s.sterz@proxmox.com>
To: "Stefan Sterz" <s.sterz@proxmox.com>, <pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.17.0-69-g65571b67d7d3-dirty
References: <20240405141257.165513-1-s.sterz@proxmox.com>
In-Reply-To: <20240405141257.165513-1-s.sterz@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -1.370 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
ENA_SUBJ_ODD_CASE 2.6 Subject has odd case
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: tape ui: unset
`deleteEmpty` in `TapeBackupWindow`
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On Fri Apr 5, 2024 at 4:12 PM CEST, Stefan Sterz wrote:
> since the api rejects unknown parameters, deleteEmpty needs to be
> unset here, because the endpoint for creating backups does not support
> deleting parameters. otherwise a user will get a fairly cryptic error
> message in the gui.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> www/tape/window/TapeBackup.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/tape/window/TapeBackup.js b/www/tape/window/TapeBackup.js
> index 941b6b83..4c027ab0 100644
> --- a/www/tape/window/TapeBackup.js
> +++ b/www/tape/window/TapeBackup.js
> @@ -39,6 +39,7 @@ Ext.define('PBS.TapeManagement.TapeBackupWindow', {
> fieldLabel: gettext('Max Depth'),
> disabled: true,
> name: 'max-depth',
> + deleteEmpty: false,
> },
> {
> xtype: 'pbsMediaPoolSelector',
ping, this is a fairly minor improvement that fixes the one of tape
backup ui
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel