From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id B70551FF56B
for <inbox@lore.proxmox.com>; Mon, 22 Apr 2024 09:38:25 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C69DD9231;
Mon, 22 Apr 2024 09:38:29 +0200 (CEST)
Mime-Version: 1.0
Date: Mon, 22 Apr 2024 09:37:53 +0200
Message-Id: <D0QHAA0WQ9FG.2BS7JHGGJF2MH@proxmox.com>
From: "Hannes Laimer" <h.laimer@proxmox.com>
To: "Dietmar Maurer" <dietmar@proxmox.com>, "Proxmox Backup Server
development discussion" <pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.17.0-78-g4ffbaa6b3946
References: <20240419155606.112010-1-h.laimer@proxmox.com>
<20240419155606.112010-7-h.laimer@proxmox.com>
<2660798.9067.1713770923522@webmail.proxmox.com>
In-Reply-To: <2660798.9067.1713770923522@webmail.proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.007 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v8 06/23] api: removable
datastore creation
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
On Mon Apr 22, 2024 at 9:28 AM CEST, Dietmar Maurer wrote:
> comments inline
>
> > /// Create new datastore config.
> > pub fn create_datastore(
> > - config: DataStoreConfig,
> > + mut config: DataStoreConfig,
> > rpcenv: &mut dyn RpcEnvironment,
> > ) -> Result<String, Error> {
> > let lock = pbs_config::datastore::lock_config()?;
> > @@ -122,6 +149,31 @@ pub fn create_datastore(
> > param_bail!("name", "datastore '{}' already exists.", config.name);
> > }
> >
> > + if let Some(uuid) = &config.backing_device {
> > + let already_used_by = section_config
> > + .sections
> > + .iter()
> > + .flat_map(|(datastore_name, (_, config))| {
> > + config
> > + .as_object()
> > + .and_then(|cfg| cfg.get("backing-device"))
> > + .and_then(|backing_device| backing_device.as_str())
> > + .filter(|&device_uuid| device_uuid == uuid)
> > + .map(|_| datastore_name)
> > + })
> > + .next();
> > +
> > + if let Some(datastore_name) = already_used_by {
> > + param_bail!(
> > + "backing-device",
> > + "device already in use by datastore '{datastore_name}'",
> > + );
> > + }
> > + if let Some(mount_point) = config.get_mount_point() {
> > + config.path = format!("{mount_point}/{}", config.path.trim_start_matches('/'));
>
> This looks redundant for me. I don't want to store the mount point
> in the datastore path.
>
we do use .path all over the place, so we really want that to be the
full path of where the datastore will be once mounted, if we don't have
the complete path(including mp) stored we'd have to add some logic
everywhere the datastore path is used
> > + }
> > + }
> > +
> > let auth_id: Authid = rpcenv.get_auth_id().unwrap().parse()?;
> > let to_stdout = rpcenv.env_type() == RpcEnvironmentType::CLI;
> >
> > --
> > 2.39.2
> >
> >
> >
> > _______________________________________________
> > pbs-devel mailing list
> > pbs-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel