From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 2F3271FF348
for <inbox@lore.proxmox.com>; Wed, 17 Apr 2024 14:50:58 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4875E6D7F;
Wed, 17 Apr 2024 14:50:58 +0200 (CEST)
Mime-Version: 1.0
Date: Wed, 17 Apr 2024 14:50:25 +0200
Message-Id: <D0MESUPS491X.2VMPO7V54UFM5@proxmox.com>
From: "Hannes Laimer" <h.laimer@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.17.0-78-g4ffbaa6b3946
References: <20240417121946.81121-1-dietmar@proxmox.com>
In-Reply-To: <20240417121946.81121-1-dietmar@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.001 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup ] datastore maintenance mode
update: correctly track maintenance mode changes
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
technically yes, but we only use this to determine if we have to clear a
cache entry, and putting a datastore out of maintenance never requires
the dropping the cache entry
On Wed Apr 17, 2024 at 2:19 PM CEST, Dietmar Maurer wrote:
> Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
> ---
> src/api2/config/datastore.rs | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs
> index 3081e1f4..dc658e35 100644
> --- a/src/api2/config/datastore.rs
> +++ b/src/api2/config/datastore.rs
> @@ -276,6 +276,8 @@ pub fn update_datastore(
>
> let mut data: DataStoreConfig = config.lookup("datastore", &name)?;
>
> + let mut maintenance_mode_changed = false;
> +
> if let Some(delete) = delete {
> for delete_prop in delete {
> match delete_prop {
> @@ -319,6 +321,9 @@ pub fn update_datastore(
> data.tuning = None;
> }
> DeletableProperty::MaintenanceMode => {
> + if data.maintenance_mode.is_some() && data.update.maintenance_mode.is_none() {
> + maintenance_mode_changed = true;
> + }
> data.maintenance_mode = None;
> }
> }
> @@ -389,7 +394,6 @@ pub fn update_datastore(
> data.tuning = update.tuning;
> }
>
> - let mut maintenance_mode_changed = false;
> if update.maintenance_mode.is_some() {
> maintenance_mode_changed = data.maintenance_mode != update.maintenance_mode;
> data.maintenance_mode = update.maintenance_mode;
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel