From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <h.laimer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 880EE949DB
for <pbs-devel@lists.proxmox.com>; Thu, 11 Apr 2024 10:16:18 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 71B6A1C2E0
for <pbs-devel@lists.proxmox.com>; Thu, 11 Apr 2024 10:16:18 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Thu, 11 Apr 2024 10:16:14 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A535E4497D
for <pbs-devel@lists.proxmox.com>; Thu, 11 Apr 2024 10:16:14 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 11 Apr 2024 10:16:13 +0200
Message-Id: <D0H57N5NH1M5.3FNG0XRP3MGNF@proxmox.com>
From: "Hannes Laimer" <h.laimer@proxmox.com>
To: "Dietmar Maurer" <dietmar@proxmox.com>, "Proxmox Backup Server
development discussion" <pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.17.0-78-g4ffbaa6b3946
References: <20240409110012.166472-1-h.laimer@proxmox.com>
<20240409110012.166472-4-h.laimer@proxmox.com>
<1680475591.6047.1712819953060@webmail.proxmox.com>
In-Reply-To: <1680475591.6047.1712819953060@webmail.proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.008 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com, maintenance.rs]
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 03/24] maintenance: add
'Unpplugged' maintenance type
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2024 08:16:18 -0000
On Thu Apr 11, 2024 at 9:19 AM CEST, Dietmar Maurer wrote:
> Maybe a stupid question, but what is the purpose of this=20
> additional maintenance type? I can see that we get a different error mess=
age, but else it behaves the same as "Offline"?
>
Functionally they are basically the same, but they are represtened
differently in the UI/(error-)messages. As we discussed off-list it
makes sense to not have the current 'state' represented in the ds
config, but rather somewhere under `/var/..` as you suggested. This is
another reason for why that is a good idea. In some way a maintenance
mode is also more of a state than a configuration, but that's different
topic.
> > On 9.4.2024 12:59 CEST Hannes Laimer <h.laimer@proxmox.com> wrote:
> >=20
> > =20
> > Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> > ---
> > pbs-api-types/src/maintenance.rs | 31 +++++++++++++++++++++++++++++--
> > 1 file changed, 29 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maint=
enance.rs
> > index a605cc17..e7ffbcd0 100644
> > --- a/pbs-api-types/src/maintenance.rs
> > +++ b/pbs-api-types/src/maintenance.rs
> > @@ -38,7 +38,6 @@ pub enum Operation {
> > /// Maintenance type.
> > pub enum MaintenanceType {
> > // TODO:
> > - // - Add "unmounting" once we got pluggable datastores
> > // - Add "GarbageCollection" or "DeleteOnly" as type and track GC=
(or all deletes) as separate
> > // operation, so that one can enable a mode where nothing new c=
an be added but stuff can be
> > // cleaned
> > @@ -48,6 +47,8 @@ pub enum MaintenanceType {
> > Offline,
> > /// The datastore is being deleted.
> > Delete,
> > + /// The removable datastore is unplugged
> > + Unplugged,
> > }
> > serde_plain::derive_display_from_serialize!(MaintenanceType);
> > serde_plain::derive_fromstr_from_deserialize!(MaintenanceType);
> > @@ -80,7 +81,7 @@ impl MaintenanceMode {
> > /// Used for deciding whether the datastore is cleared from the in=
ternal cache after the last
> > /// task finishes, so all open files are closed.
> > pub fn is_offline(&self) -> bool {
> > - self.ty =3D=3D MaintenanceType::Offline
> > + self.ty =3D=3D MaintenanceType::Offline || self.ty =3D=3D Main=
tenanceType::Unplugged
> > }
> > =20
> > pub fn check(&self, operation: Option<Operation>) -> Result<(), Er=
ror> {
> > @@ -96,6 +97,8 @@ impl MaintenanceMode {
> > return Ok(());
> > } else if self.ty =3D=3D MaintenanceType::Offline {
> > bail!("offline maintenance mode: {}", message);
> > + } else if self.ty =3D=3D MaintenanceType::Unplugged {
> > + bail!("datastore is not plugged in");
> > } else if self.ty =3D=3D MaintenanceType::ReadOnly {
> > if let Some(Operation::Write) =3D operation {
> > bail!("read-only maintenance mode: {}", message);
> > @@ -104,3 +107,27 @@ impl MaintenanceMode {
> > Ok(())
> > }
> > }
> > +
> > +#[test]
> > +fn test_check() {
> > + let ro_mode =3D MaintenanceMode::new(MaintenanceType::ReadOnly, No=
ne);
> > + let offline_mode =3D MaintenanceMode::new(MaintenanceType::Offline=
, None);
> > + let delete_mode =3D MaintenanceMode::new(MaintenanceType::Delete, =
None);
> > + let unplugged_mode =3D MaintenanceMode::new(MaintenanceType::Unplu=
gged, None);
> > +
> > + assert!(ro_mode.check(Some(Operation::Lookup)).is_ok());
> > + assert!(ro_mode.check(Some(Operation::Read)).is_ok());
> > + assert!(ro_mode.check(Some(Operation::Write)).is_err());
> > +
> > + assert!(offline_mode.check(Some(Operation::Lookup)).is_ok());
> > + assert!(offline_mode.check(Some(Operation::Read)).is_err());
> > + assert!(offline_mode.check(Some(Operation::Write)).is_err());
> > +
> > + assert!(delete_mode.check(Some(Operation::Lookup)).is_err());
> > + assert!(delete_mode.check(Some(Operation::Read)).is_err());
> > + assert!(delete_mode.check(Some(Operation::Write)).is_err());
> > +
> > + assert!(unplugged_mode.check(Some(Operation::Lookup)).is_ok());
> > + assert!(unplugged_mode.check(Some(Operation::Read)).is_err());
> > + assert!(unplugged_mode.check(Some(Operation::Write)).is_err());
> > +}
> > --=20
> > 2.39.2
> >=20
> >=20
> >=20
> > _______________________________________________
> > pbs-devel mailing list
> > pbs-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel