From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <m.carrara@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7F2C4BB7DD for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 14:25:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D8AD4EE5 for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 14:24:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 14:24:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 99EA041EA2 for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 14:24:44 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Mon, 25 Mar 2024 14:24:43 +0100 Message-Id: <D02V4L8SIP11.1L2BJAE93UENN@proxmox.com> From: "Max Carrara" <m.carrara@proxmox.com> To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.17.0-72-g6a84f1331f1c References: <20240307151319.301984-2-s.lendl@proxmox.com> In-Reply-To: <20240307151319.301984-2-s.lendl@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 pve-network 0/5] SDN tests in sbuild X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 25 Mar 2024 13:25:15 -0000 On Thu Mar 7, 2024 at 4:13 PM CET, Stefan Lendl wrote: > Extract and mock functions that otherwise access system files which is no= t > possible in a clean sbuild environment. > Namely /etc/network/interfaces as well as /etc/frr/frr.config.local > Disabling DNS tests > > Changes v1 -> v2: > * Disabled DNS tests because they fail > Looked through it all and ran the tests manually and also indirectly via builds - looks pretty good to me! Always fond of making things more testable! :) There are some minor comments inline - but one important thing: The DNS tests are passing for me. Maybe double-check if they pass for you now too; if that's the case, patch #4 can just be dropped, as mentioned in my comment. Otherwise: Reviewed-by: Max Carrara <m.carrara@proxmox.com> Tested-by: Max Carrara <m.carrara@proxmox.com> > > Stefan Lendl (5): > refactor(controllers): extract read_etc_network_interfaces > refactor(evpn): extract read_local_frr_config > tests: mocking more functions to avoid system access > tests: disable failing DNS tests > tests: run tests in sbuild > > src/Makefile | 2 +- > src/PVE/Network/SDN/Controllers.pm | 16 ++++++--- > src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 10 ++++-- > src/test/Makefile | 2 +- > src/test/run_test_zones.pl | 36 ++++++++++++++++++- > 5 files changed, 56 insertions(+), 10 deletions(-)