From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <g.goller@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 7F54993D3C
for <pbs-devel@lists.proxmox.com>; Wed, 7 Feb 2024 10:30:49 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 67352E7B2
for <pbs-devel@lists.proxmox.com>; Wed, 7 Feb 2024 10:30:49 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Wed, 7 Feb 2024 10:30:45 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 03D3544B0D
for <pbs-devel@lists.proxmox.com>; Wed, 7 Feb 2024 10:30:45 +0100 (CET)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 07 Feb 2024 10:30:44 +0100
Message-Id: <CYYQPTSF2FK9.2TYMC599MJDCI@proxmox.com>
From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
X-Mailer: aerc 0.16.0-149-g2d8b81f619fc
References: <20240206145142.1175527-2-s.lendl@proxmox.com>
<20240206145142.1175527-10-s.lendl@proxmox.com>
In-Reply-To: <20240206145142.1175527-10-s.lendl@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.108 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 8/8] gc: configure width
and flex on GC Jobs columns
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2024 09:30:49 -0000
On Tue Feb 6, 2024 at 3:51 PM CET, Stefan Lendl wrote:
> table expands to the full width and relevant data is still visible on a
> narrow screen.
>
> Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
> ---
> www/config/GCView.js | 30 +++++++++++++++++++-----------
> 1 file changed, 19 insertions(+), 11 deletions(-)
>
> diff --git a/www/config/GCView.js b/www/config/GCView.js
> index d1f1bf71..796057ff 100644
> --- a/www/config/GCView.js
> +++ b/www/config/GCView.js
> @@ -159,63 +159,71 @@ Ext.define('PBS.config.GCJobView', {
> header: gettext('Datastore'),
> dataIndex: 'store',
> renderer: Ext.String.htmlEncode,
> - width: 120,
> sortable: true,
> hideable: false,
> + width: 150,
> + minWidth: 120,
> + maxWidth: 300,
> + flex: 2,
Indentation here (and on the other additions in the same file) looks off...
Check the internal wiki for our styleguide :)