From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <aderumier@odiso.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5C20D66CA2 for <pve-devel@lists.proxmox.com>; Sun, 8 Nov 2020 15:10:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A4F1E853 for <pve-devel@lists.proxmox.com>; Sun, 8 Nov 2020 15:10:49 +0100 (CET) Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AC97AE846 for <pve-devel@lists.proxmox.com>; Sun, 8 Nov 2020 15:10:47 +0100 (CET) Received: by mail-lf1-x134.google.com with SMTP id f11so2172530lfs.3 for <pve-devel@lists.proxmox.com>; Sun, 08 Nov 2020 06:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0Sb9qQouu6Wua/XDNey4t7nt2rpQUkxo13w835HsIew=; b=c/IkJN8EP0qNKEFKDtC6QiR6i18mxaggwQ4L5AHhHC0uzTo3VQy7e3/69GvLSfca8m MJyRRB7GbCKMO24YrWEE1lb/wxA1laNbA29lW1bEq0OyiLDFe7NW1IJtlyhgo8XWh+PB rGU6FuIWsPEHh6fmZuZzFQ4Tf5hPVEadt8UC3G6LWERJDwWUpzBJ4j+6D7qSPXSi/c/3 CCz36DdHegrEXafBk+2gjDS7TEcoqkNezlYiI5u1nh9UKVAxzhu5sw68cOYPKRIcz6H/ CZVvZJTP2zJsj8yxwrMyi6T+urcCzwIH4oC87xAaRc94XlCjq16PD12TTNbnZBc/xlH3 oF1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0Sb9qQouu6Wua/XDNey4t7nt2rpQUkxo13w835HsIew=; b=DQbVQNxCq9tISvC1pMzq1yakFM68jRzVHAMB3jkHAHCO6P47SraA/fhpiQDO7Px6lI tjHbz9lQCOinKpPpoB9/5KllAWewcmHuzFaqsZXWLbdU/BAEUpJ9ZG/OpF/5saLpoyYz 6TwcqYbrczlYtdFl+Oty6K/tPeaRm+0qurHdro9R6JFc1TLAaa6mbORS9YQzQKwEtP1l scS7PuD1qTVPAxHsRlYakq8VXxI5Onbb3GmLnOgOyCYrYaUCr2osar7vy+3SELj+3hkI 9bDsEkIiJJ6baRxWN4fChPTP9Xd3su9q/ZlITifGW0UkJAUGoHqu7zF+OiEQlK9y1yVw x94g== X-Gm-Message-State: AOAM53327vRj45lSkYArJvu/wVMjtOoF/5Q84VXcREOPVTiudgUAGCMV H+6qmyBdjkqUKcJKL1rI41EDmwVGbuKNQUYelPwq5qKSHdBk9A== X-Google-Smtp-Source: ABdhPJyhaW7lquomX1AJRPFdn5bDMP2lIRJQoGoILkIv0h/QETtk3TflBgkATtAPjNvX5nBpRhAGo2p4aJhngNUoxRU= X-Received: by 2002:a19:915:: with SMTP id 21mr3924032lfj.528.1604844640917; Sun, 08 Nov 2020 06:10:40 -0800 (PST) MIME-Version: 1.0 References: <20201106082455.3288332-1-aderumier@odiso.com> <5cb36606-8982-52d1-a342-720eec24c453@proxmox.com> In-Reply-To: <5cb36606-8982-52d1-a342-720eec24c453@proxmox.com> From: Alexandre Derumier <aderumier@odiso.com> Date: Sun, 8 Nov 2020 15:10:30 +0100 Message-ID: <CAMGxVzBtNkNM_4_7za6P3TeHNDCu7YbWqWv4jJM7LwOEp9rxKA@mail.gmail.com> To: Thomas Lamprecht <t.lamprecht@proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.127 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cgroup.pm, systemd.pm, proxmox.com] Subject: Re: [pve-devel] applied-series: [PATCH V2 pve-common 0/4] add generic CGroup module X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Sun, 08 Nov 2020 14:10:49 -0000 Thanks Thomas, don't forget related pve-container && qemu-server patches https://lists.proxmox.com/pipermail/pve-devel/2020-October/045714.html https://lists.proxmox.com/pipermail/pve-devel/2020-October/045720.html Le ven. 6 nov. 2020 =C3=A0 09:31, Thomas Lamprecht <t.lamprecht@proxmox.com> a =C3=A9crit : > > On 06.11.20 09:24, Alexandre Derumier wrote: > > This move Cgroup module from LXC to pve-common, > > to be able to use it in qemu-server too. > > (and add support for cgroupv2 only for qemu) > > > > I have also included a bugfix for cpushares from cgroup v1, > > when value is not defined,it's currently set to 100 instead 1024. > > (can be trigerred by pct --delete cpuunits) > > > > > > Changelog v2: > > > > - keep get_subdir in base class > > > > Alexandre Derumier (4): > > move PVE::LXC::CGroup to PVE::CGroup > > Cgroups: remove specific lxc code > > bugfix: cpushares : default value is 1024 for cgroup v1 > > systemd: add CPUWeight encoding > > > > src/Makefile | 1 + > > src/PVE/CGroup.pm | 551 +++++++++++++++++++++++++++++++++++++++++++++ > > src/PVE/Systemd.pm | 2 +- > > 3 files changed, 553 insertions(+), 1 deletion(-) > > create mode 100644 src/PVE/CGroup.pm > > > > > > applied series, thanks! >