From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0D9661FF173 for ; Sun, 8 Jun 2025 16:26:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1BCB43035A; Sun, 8 Jun 2025 16:26:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ayufan-eu.20230601.gappssmtp.com; s=20230601; t=1749392750; x=1749997550; darn=lists.proxmox.com; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=ElnoCW5dHUVsDk+MPQp5qL/nWWIrZoy3Q15KdnKe0yk=; b=kznBub8Q8ixc/mrCbDqKRX9UneVU0Zmqs5+cGdo3Gge4LRZCo5aFeDCiyjynSLKr8q MoRDuFypdsuSWwlyuQlSMnh7H1iQtRdddddyuAavYfHak5kFC6YUX0/h9gKT/HfUEzr3 ABYDahQQuUvj6Jw2+Zu1WR4bhIB+v3PdjQj2xkxfjcAscBMCT85WnClINsMWugYRNjsW qp80LfQh1Pcr/0QlovXt/Jxe7bMMiH+gDnH2XtSl4WP4ahrottu6dj496tzxoFXUW//g Ch5Wj4RUiEB1n6gS6meHsXrUrd05A46EG4Z+xwjC3ecN5V+RkaZn+4pCDnWbNzSNBAP9 DIcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749392750; x=1749997550; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ElnoCW5dHUVsDk+MPQp5qL/nWWIrZoy3Q15KdnKe0yk=; b=UpwSjoaEs7NA98+UJfpH/4RzxWzvP2uHChsO6lIvQhkOrNDLvt9Plpb/uaJj7d5edw ij3PD+FC33nlEO88ZG/rysYEcOuIb5FQbtNcHepHkLzBnyOqZPUins3cpezi9nA5xn0o kShuXzA/KGWZ9D658xc8iF3ozvrKb5hdpDzaU/9Y6mhnCp2sDquoqD3uoqHugA7VPYYG iEVA7FzUeUUAmKJfSZMI9akwCIfVoFZRrGFfvdUHuaMeuvU/1czjIdIYIsLwGD2uOcGU HfHKdR4nbVs+Nc/t+seO3vRKCVsejX79w+qhOpbOQlq5cOEGD+yGhuKoT41YzvrGXbAl 8ULA== X-Gm-Message-State: AOJu0YwJHe7trB0n9WwM/IVsHRiL9OiqlyGwnO/QKkGQEFLVTDSJDnQm IKhN8DOJixkI3el1tlVQMZoERo2tvg9ihecVVpLFEe70xsUE3Gyd/ioMT+Mew6H3uDllLAkPm9h Lq+37S+uvbnxZptlXI7nHYvXZWvEvBnqkRBFbfVu9UFLzVSq8ugTzWeQC5X8= X-Gm-Gg: ASbGnct0cwEIzYKoYZUB7pZo3rHeTFjXjqcMPEmyishie38uCtZ1BssEo4RUJRPCRI9 3gn1P9foiOdBHcI506e4UloX3IgMgDsCxbY6m1ve+mKq8yl+QjS6Jy6Pz6w8XEypHPPEXZ+bZKh zggdVtiFcVBaMm+UpgoBpHlBzdmgmqcAyhKuFJibX3IklkhJVEtoHrch8= X-Google-Smtp-Source: AGHT+IFBKWGuKhRJtgYpsjMzelpU6PFTiRuJHDirnbkmjcgVngT77kua24pLgoJLGFjvecZdSVaiHl+dd9wrs+yBVf0= X-Received: by 2002:a17:907:1c0a:b0:acb:abff:a5b6 with SMTP id a640c23a62f3a-ade1aa4d0c6mr803190366b.13.1749392750198; Sun, 08 Jun 2025 07:25:50 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Kamil_Trzci=C5=84ski?= Date: Sun, 8 Jun 2025 16:25:38 +0200 X-Gm-Features: AX0GCFtgXejald_T0jca6FAYR2VKLce7s5MDVkg63aQcTWJnSJPEqnMHyiybHJQ Message-ID: To: pve-devel@lists.proxmox.com X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DMARC_MISSING 0.1 Missing DMARC policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] Further improvement to GC X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thanks for introducing LRU Cache. I have another suggestion that we further the sweep phase could be improved: 1. The sweep_unused_chunks could use LRU cache to avoid lstatat if object is found in cache. The lstatat would only be required for potential objects that might have been added while running GC cycle, or that might have been evicted from LRU cache. For big enough LRU caches and the fact that only small amount of objects are usually removed this should make the GC almost in-memory. 2. The process could add a warning that LRU cache is too small, and propose the value big enough to avoid cache eviction based on number of chunks observed. Kamil _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel