From: "Kamil Trzciński" <ayufan@ayufan.eu>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] Further improvement to GC
Date: Sun, 8 Jun 2025 16:25:38 +0200 [thread overview]
Message-ID: <CAJ-Uff=kmckbVpUKYqCYtaCzfP+zJd=VsWmE3qPxryzXQYbawA@mail.gmail.com> (raw)
Thanks for introducing LRU Cache.
I have another suggestion that we further the sweep phase could be improved:
1. The sweep_unused_chunks could use LRU cache to avoid lstatat if
object is found in cache.
The lstatat would only be required for potential objects that might
have been added while running GC cycle, or that might have been
evicted from LRU cache.
For big enough LRU caches and the fact that only small amount of
objects are usually removed this should make the GC almost in-memory.
2. The process could add a warning that LRU cache is too small, and
propose the value big enough to avoid cache eviction based on number
of chunks observed.
Kamil
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-06-08 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-08 14:25 Kamil Trzciński [this message]
2025-06-10 7:20 ` Christian Ebner
2025-06-11 6:11 ` Kamil Trzciński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ-Uff=kmckbVpUKYqCYtaCzfP+zJd=VsWmE3qPxryzXQYbawA@mail.gmail.com' \
--to=ayufan@ayufan.eu \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.