From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <daniel@bowdernet.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 89D7271519 for <pve-devel@lists.proxmox.com>; Wed, 8 Jun 2022 15:44:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 783B7966E for <pve-devel@lists.proxmox.com>; Wed, 8 Jun 2022 15:43:55 +0200 (CEST) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 30FA6965B for <pve-devel@lists.proxmox.com>; Wed, 8 Jun 2022 15:43:53 +0200 (CEST) Received: by mail-qk1-x72d.google.com with SMTP id bi27so8922181qkb.10 for <pve-devel@lists.proxmox.com>; Wed, 08 Jun 2022 06:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bowdernet.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ifbeWnwUYqz/d5hxW/16+6jv89XzVYS1Uo0oYjZ+hLY=; b=XO0uvXrPrJCwO2D9bUKuMj6aiOlQVcasFxs3ifwRfpm1DTJ6HwfQtQ7E5mh+MNu9EO 4XH4+3sRxeIe4b/nNiimTqhPGkFbbBaeoGLDuaS/T1eUJJpAGXQ8ZBXXtZ2hOTdWh/02 6aATBWDQZeQ1vj+U0evS7YMOItbIaYCWaJlbzZzV9+7c0rwp+9UrV5sJOsvS28W84jlR hYq5du9SMrickUpa1Lu3mOu2EldAityQQEKsBnWnwnTawGMpHUpamIIfN/A/JU8FLz05 YYkogvMxubrAKerdrHY8Zr3ujkKYZD1tlhVOZniflkWp5z45UeJXVyGRbTE9BVmr+Uya 9kww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ifbeWnwUYqz/d5hxW/16+6jv89XzVYS1Uo0oYjZ+hLY=; b=Cx5roaV5TZn1Hn9fHY1lrhpEbZWn1BZJb2+/X6kyF0+CuMifQM7VjL8ODgtXloE0wG MqyQ4XQ3WXH75iO3kLW2IplSp+mudGZI1Zc7BGlLWg2y4WLJCLm5RadpRh2HXOaGeYwa CcSYh4Uxm2Zhww2EMdPJmJLlpaOd87+LLfJnxK0OHCFBEMueypNfB9j/QTefBWf/QqHk BMtepocb5Ef6/S08UivhAZa+oY/2vzIFZsPde7YBv87rtaqSjyx5Mra2pZk4ETy1qCTJ qGqIHZUQecHiFwBgHDVrSBzRcw8ehcXh14LbNJzl3dZVpH7bcSbPQ2239DAk+WMY1t+/ +M6Q== X-Gm-Message-State: AOAM533ElhFZKOWjl9DWDuJ0OljR+oalgsVyuVI24wOqY6SitN0vizrZ T7iEPlNBPvh/3F4gH1HO1QfwyeDGcba8r2KF X-Google-Smtp-Source: ABdhPJyUZ5g2h4aygtyJA9SvJj3SHfvOomcycBfX/+yym9SR0fi/G0PqmN/ZIBAhyIDjfwkrGZc4Bw== X-Received: by 2002:a37:9c50:0:b0:6a6:a208:d5d4 with SMTP id f77-20020a379c50000000b006a6a208d5d4mr17506086qke.467.1654695830627; Wed, 08 Jun 2022 06:43:50 -0700 (PDT) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com. [209.85.219.173]) by smtp.gmail.com with ESMTPSA id w4-20020a05620a444400b006a6278a2b31sm7402205qkp.75.2022.06.08.06.43.49 for <pve-devel@lists.proxmox.com> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 06:43:50 -0700 (PDT) Received: by mail-yb1-f173.google.com with SMTP id r82so36525741ybc.13 for <pve-devel@lists.proxmox.com>; Wed, 08 Jun 2022 06:43:49 -0700 (PDT) X-Received: by 2002:a25:5016:0:b0:663:fc34:a602 with SMTP id e22-20020a255016000000b00663fc34a602mr3667247ybb.272.1654695829628; Wed, 08 Jun 2022 06:43:49 -0700 (PDT) MIME-Version: 1.0 References: <20220608115428.250668-1-daniel@bowdernet.com> <7b52e845-3bc7-01b3-6882-358739a6d5b9@proxmox.com> <CA+=Vt22YwwpFSLxXm+q6SFEF1hPCU97Z1bQQ_n==gaAoDFaU8A@mail.gmail.com> <5893ce79-408c-b4e8-751b-40a0d39c8e83@proxmox.com> In-Reply-To: <5893ce79-408c-b4e8-751b-40a0d39c8e83@proxmox.com> From: Daniel Bowder <daniel@bowdernet.com> Date: Wed, 8 Jun 2022 06:43:23 -0700 X-Gmail-Original-Message-ID: <CA+=Vt231bmO_nDmmiz7dUxzB957Nik2Gp_wEOtjkmhqh==RO+w@mail.gmail.com> Message-ID: <CA+=Vt231bmO_nDmmiz7dUxzB957Nik2Gp_wEOtjkmhqh==RO+w@mail.gmail.com> To: Matthias Heiserer <m.heiserer@proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain HTML_MESSAGE 0.001 HTML included in message RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [bowdernet.com, proxmox.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 08 Jun 2022 13:44:25 -0000 > Yes, exactly! Make sure to also add a version in the commit message(e.g: > "[pve-devel] [PATCH v2 pve-manager 4/5] fix #3593"), and describe which > changes were made since the last version. You can take a look at other > mails so see how it is done: > https://lists.proxmox.com/pipermail/pve-devel/, and in the Developer > Documentation in the section "Preparing Patches". > I suggest you wait a bit before sending in a v2, I'll first test your patch. Sounds good. I will: 1. read up on Preparing Patches 2. correct my formatting settings 3. wait to hear your feedback for incorporation with v2 On Wed, Jun 8, 2022 at 6:32 AM Matthias Heiserer <m.heiserer@proxmox.com> wrote: > On 08.06.2022 15:21, Daniel Bowder wrote: > >> Thank you for your patches! > > You are welcome. > > > >> Regarding the formatting: Please make sure to follow our Perl and > >> Javascript style guides [0][1] and the Developer Documentation [2]. All > >> your patches use a nonconformant indentation :/ > > I do apologize for that. I read [0] and [2] in their entirety multiple > > times. I was very careful to make sure I didn't have any lines that were > > > > 100 chars and I tried to follow the formatting guidelines. I'll need to > fix > > my editor to match the indentation specifications. > No worries, the formatting is a bit unusual. > > > > >> Also, the repository (e.g. qemu-server) should be part of the prefix, > >> next to "PATCH", this makes it easier to parse where they belong. > > The instructions on [2] under #Preparing_Patches are a little ambiguous > > when it comes to changes to multiple repos that are all related. > > Specifically when making changes to multiple repos for one related task. > > > > # cd pve-manager; git format-patch -s -o /tmp/patchq -1 > > # cd ../pve-guest-common; git format-patch -s -o /tmp/patchq -1 > > # cd ../pve-docs; git format-patch -s -o /tmp/patchq -1 > > # git send-email --compose --to=pve-devel@lists.proxmox.com > /tmp/patchq/* > > > > I didn't follow these completely blindly, but, I also wasn't 100% certain > > what to change for a multi-repo review vs a single repo review. I'll > make > > sure to include [ PATCH xxxx a/b ] for each xxxx repo patch in the > future. > > > >> In case you haven't done so yet, we require a CLA (explained in [2]) > >> from you in order to use your code. > > I sent in the CLA just before submitting the patches. > > Great!> > > I'm somewhat of a noob when it comes to mailing lists as opposed to > working > > off of branches in a repo. Do I resubmit my patches in the same way that > I > > did previously after I've resolved the indentation issues? > > > Yes, exactly! Make sure to also add a version in the commit message(e.g: > "[pve-devel] [PATCH v2 pve-manager 4/5] fix #3593"), and describe which > changes were made since the last version. You can take a look at other > mails so see how it is done: > https://lists.proxmox.com/pipermail/pve-devel/, and in the Developer > Documentation in the section "Preparing Patches". > > I suggest you wait a bit before sending in a v2, I'll first test your > patch. > > > > On Wed, Jun 8, 2022 at 6:00 AM Matthias Heiserer <m.heiserer@proxmox.com > > > > wrote: > > > >> On 08.06.2022 13:54, Daniel Bowder wrote: > >>> These five patches add the ability to pin a QEMU VMs processes to a > >> defined set of CPU cores. The changes required spanned multiple repos > and > >> have all been included in these five patches. The patches add "cpuset" > as > >> an option in the qm configuration file and enable the editing of this > >> parameter via the gui. > >>> > >> > >> Thank you for your patches! > >> > >> Regarding the formatting: Please make sure to follow our Perl and > >> Javascript style guides [0][1] and the Developer Documentation [2]. All > >> your patches use a nonconformant indentation :/ > >> Also, the repository (e.g. qemu-server) should be part of the prefix, > >> next to "PATCH", this makes it easier to parse where they belong. > >> > >> In case you haven't done so yet, we require a CLA (explained in [2]) > >> from you in order to use your code. > >> > >> > >> [0] https://pve.proxmox.com/wiki/Perl_Style_Guide > >> [1] https://pve.proxmox.com/wiki/Javascript_Style_Guide > >> [2] https://pve.proxmox.com/wiki/Developer_Documentation > >> > >> > > > > >