From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <daniel@bowdernet.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2F86071472 for <pve-devel@lists.proxmox.com>; Wed, 8 Jun 2022 15:22:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F3CA9215 for <pve-devel@lists.proxmox.com>; Wed, 8 Jun 2022 15:22:11 +0200 (CEST) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E056D9200 for <pve-devel@lists.proxmox.com>; Wed, 8 Jun 2022 15:22:09 +0200 (CEST) Received: by mail-qk1-x72d.google.com with SMTP id 68so7002521qkk.9 for <pve-devel@lists.proxmox.com>; Wed, 08 Jun 2022 06:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bowdernet.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/IUZ9VxLt9oc1g+Tzu4sEGkhpRCSoIHuXpUlOop1hKI=; b=AnkwHaVHtYOttGy91ftFvlvwST3qojSGEUfCbLnJQGCBhPH2x9WyC6+CCgEP9DBA8M +KyMcD+D887ZLKBhG9cb34TXSJKArK5boNboZqbWA/esz/Kq5YH2H1QAzQesgVvzPE8X yX+ll1Mput9zX/ViWEKN7b5lyNmSdM7H446X5m9N7sr9qiIoaqekw8DSr6QUfzEE4CmQ Pj+TgA4XEDp5St+3cYm19S6vRv2EKSOM8ym6LbKndwoV8Alo9gWJ3dwOanspuftEWLOE kRGzYpZLJlWM+EWEZtLvX/nhDw/puyQymvk9CaX1oxnN2GEFMYu07mv6/E8yP4EihxfC qDxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/IUZ9VxLt9oc1g+Tzu4sEGkhpRCSoIHuXpUlOop1hKI=; b=5ApFFD4jXgYZln/mNeVqFURr5L4tmEiHhM/eeXCZ+3E/i6rkGf5ikAd2rM9KxHs/8g 1lnEOespjp7GktBPDx7xFJgDLXJf08aS3S5blL0dfgisgk8NJAegFfqpZ9UMYNcef8Ne QqVS/YB7dZYlgSd1eLNx9/UeetTNwiWAswqq76ShP2xlKcFDh37/GejGdkKyUVySgdkd 340V3Soo45f1mv1Muqka6y8NGdspaD2tbZHaHtZdYPJDmELfO5q3h8LMrNDDx0PQjaqQ KJjbQdtaTAmvoORKC+9yRbIvqZaVPYbirdBRUlzHORSMby7NQloPLqbGqpsNCBlNM/YL DHCQ== X-Gm-Message-State: AOAM533YncOCK56PllN2/3xeMzwVg7TCr5+53t7ukWooU650PqYN3v3m OyzD4iIcyitCXOfV4bznOND5b7Xluxa4z9r3 X-Google-Smtp-Source: ABdhPJxRxGma8HHY/HA5iwqayEW4b6p1LzA2+28KdkQZ9TeDhi1xMAa7Kb9pxk3BO4WBvshdzwT/+g== X-Received: by 2002:a05:620a:1911:b0:6a6:e8e9:70cd with SMTP id bj17-20020a05620a191100b006a6e8e970cdmr4913659qkb.627.1654694522180; Wed, 08 Jun 2022 06:22:02 -0700 (PDT) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id v5-20020a05620a0f0500b006a6a1bae173sm12388034qkl.7.2022.06.08.06.22.01 for <pve-devel@lists.proxmox.com> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 06:22:01 -0700 (PDT) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-30c143c41e5so208739867b3.3 for <pve-devel@lists.proxmox.com>; Wed, 08 Jun 2022 06:22:01 -0700 (PDT) X-Received: by 2002:a81:184b:0:b0:30c:846e:e2b with SMTP id 72-20020a81184b000000b0030c846e0e2bmr38125307ywy.97.1654694521428; Wed, 08 Jun 2022 06:22:01 -0700 (PDT) MIME-Version: 1.0 References: <20220608115428.250668-1-daniel@bowdernet.com> <7b52e845-3bc7-01b3-6882-358739a6d5b9@proxmox.com> In-Reply-To: <7b52e845-3bc7-01b3-6882-358739a6d5b9@proxmox.com> From: Daniel Bowder <daniel@bowdernet.com> Date: Wed, 8 Jun 2022 06:21:35 -0700 X-Gmail-Original-Message-ID: <CA+=Vt22YwwpFSLxXm+q6SFEF1hPCU97Z1bQQ_n==gaAoDFaU8A@mail.gmail.com> Message-ID: <CA+=Vt22YwwpFSLxXm+q6SFEF1hPCU97Z1bQQ_n==gaAoDFaU8A@mail.gmail.com> To: Matthias Heiserer <m.heiserer@proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain HTML_MESSAGE 0.001 HTML included in message RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [bowdernet.com, proxmox.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 08 Jun 2022 13:22:41 -0000 > Thank you for your patches! You are welcome. > Regarding the formatting: Please make sure to follow our Perl and > Javascript style guides [0][1] and the Developer Documentation [2]. All > your patches use a nonconformant indentation :/ I do apologize for that. I read [0] and [2] in their entirety multiple times. I was very careful to make sure I didn't have any lines that were > 100 chars and I tried to follow the formatting guidelines. I'll need to fix my editor to match the indentation specifications. > Also, the repository (e.g. qemu-server) should be part of the prefix, > next to "PATCH", this makes it easier to parse where they belong. The instructions on [2] under #Preparing_Patches are a little ambiguous when it comes to changes to multiple repos that are all related. Specifically when making changes to multiple repos for one related task. # cd pve-manager; git format-patch -s -o /tmp/patchq -1 # cd ../pve-guest-common; git format-patch -s -o /tmp/patchq -1 # cd ../pve-docs; git format-patch -s -o /tmp/patchq -1 # git send-email --compose --to=pve-devel@lists.proxmox.com /tmp/patchq/* I didn't follow these completely blindly, but, I also wasn't 100% certain what to change for a multi-repo review vs a single repo review. I'll make sure to include [ PATCH xxxx a/b ] for each xxxx repo patch in the future. > In case you haven't done so yet, we require a CLA (explained in [2]) > from you in order to use your code. I sent in the CLA just before submitting the patches. I'm somewhat of a noob when it comes to mailing lists as opposed to working off of branches in a repo. Do I resubmit my patches in the same way that I did previously after I've resolved the indentation issues? On Wed, Jun 8, 2022 at 6:00 AM Matthias Heiserer <m.heiserer@proxmox.com> wrote: > On 08.06.2022 13:54, Daniel Bowder wrote: > > These five patches add the ability to pin a QEMU VMs processes to a > defined set of CPU cores. The changes required spanned multiple repos and > have all been included in these five patches. The patches add "cpuset" as > an option in the qm configuration file and enable the editing of this > parameter via the gui. > > > > Thank you for your patches! > > Regarding the formatting: Please make sure to follow our Perl and > Javascript style guides [0][1] and the Developer Documentation [2]. All > your patches use a nonconformant indentation :/ > Also, the repository (e.g. qemu-server) should be part of the prefix, > next to "PATCH", this makes it easier to parse where they belong. > > In case you haven't done so yet, we require a CLA (explained in [2]) > from you in order to use your code. > > > [0] https://pve.proxmox.com/wiki/Perl_Style_Guide > [1] https://pve.proxmox.com/wiki/Javascript_Style_Guide > [2] https://pve.proxmox.com/wiki/Developer_Documentation > >