From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with UTF8SMTPS id 41233600E9
 for <pbs-devel@lists.proxmox.com>; Fri,  5 Feb 2021 15:28:30 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with UTF8SMTP id 1D26F9A8C
 for <pbs-devel@lists.proxmox.com>; Fri,  5 Feb 2021 15:28:00 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id A13599A7F
 for <pbs-devel@lists.proxmox.com>; Fri,  5 Feb 2021 15:27:59 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 69184461E8
 for <pbs-devel@lists.proxmox.com>; Fri,  5 Feb 2021 15:27:59 +0100 (CET)
Message-ID: <9bf76ae8-e53f-c2b4-e6c9-e8d5ca34cfe0@proxmox.com>
Date: Fri, 5 Feb 2021 15:27:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101
 Thunderbird/86.0
Content-Language: en-US
To: pbs-devel@lists.proxmox.com
References: <20210205142620.380-1-d.csapak@proxmox.com>
 <20210205142620.380-3-d.csapak@proxmox.com>
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20210205142620.380-3-d.csapak@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.324 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.182 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/5] ui: tape/ChangerStatus:
 add inventory button
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 05 Feb 2021 14:28:30 -0000

On 2/5/21 15:26, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   www/tape/ChangerStatus.js | 39 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 39 insertions(+)
> 
> diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
> index abe652b9..c80c63cd 100644
> --- a/www/tape/ChangerStatus.js
> +++ b/www/tape/ChangerStatus.js
> @@ -341,6 +341,36 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
>   	    }).show();
>   	},
>   
> +	inventory: function() {
> +	    let me = this;
> +	    let vm = me.getViewModel();
> +	    let changer = vm.get('changer');
> +	    if (changer === '') {
> +		return;
> +	    }
> +
> +	    Ext.create('Proxmox.window.Edit', {
> +		title: gettext('Barcode Label'),

that should ofc be 'Inventory' instead ...
i can send a v2 or a fixup...

> +		showTaskViewer: true,
> +		method: 'PUT',
> +		url: '/api2/extjs/tape/drive',
> +		submitUrl: function(url, values) {
> +		    let drive = values.drive;
> +		    delete values.drive;
> +		    return `${url}/${encodeURIComponent(drive)}/inventory`;
> +		},
> +
> +		items: [
> +		    {
> +			xtype: 'pbsDriveSelector',
> +			fieldLabel: gettext('Drive'),
> +			name: 'drive',
> +			changer: changer,
> +		    },
> +		],
> +	    }).show();
> +	},
> +
>   	reload: async function() {
>   	    let me = this;
>   	    let view = me.getView();
> @@ -440,6 +470,15 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
>   		disabled: '{!changerSelected}',
>   	    },
>   	},
> +	{
> +	    text: gettext('Inventory'),
> +	    xtype: 'proxmoxButton',
> +	    handler: 'inventory',
> +	    iconCls: 'fa fa-book',
> +	    bind: {
> +		disabled: '{!changerSelected}',
> +	    },
> +	},
>       ],
>   
>       layout: 'auto',
>