From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 63E8B1FF13F for ; Thu, 26 Mar 2026 13:54:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CB1FE11542; Thu, 26 Mar 2026 13:55:05 +0100 (CET) Message-ID: <9bb47f57-f91d-4090-8b02-63014549686a@proxmox.com> Date: Thu, 26 Mar 2026 13:55:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager] ceph: init: drop deprecated pg_bits parameter To: Kefu Chai , pve-devel@lists.proxmox.com References: <20260325043120.2289935-1-k.chai@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260325043120.2289935-1-k.chai@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774529651953 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KCXWCY4BRQQKEXIKAZW6A5XYQ6ZKAYMR X-Message-ID-Hash: KCXWCY4BRQQKEXIKAZW6A5XYQ6ZKAYMR X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 25.03.26 um 05:30 schrieb Kefu Chai: > The pg_bits parameter was deprecated in commit 9b15baf (PVE 8) after the > underlying Ceph config options (osd_pg_bits / osd_pgp_bits) were removed > from Ceph in v13.0.2. The implementation was made a no-op at that point, > with a TODO to remove the parameter declaration in PVE 9. > > We are now at pve-manager 9.1.6. The minimum Ceph version supported by > pveceph init is Nautilus (v14), which is already past the point where > these options existed, so the parameter has been a guaranteed no-op on > every cluster PVE 9 can manage. Remove it along with the adjacent > dead-code comments. > > Signed-off-by: Kefu Chai > --- > PVE/API2/Ceph.pm | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm > index 231b751c..f59caf16 100644 > --- a/PVE/API2/Ceph.pm > +++ b/PVE/API2/Ceph.pm > @@ -161,17 +161,6 @@ __PACKAGE__->register_method({ > minimum => 1, > maximum => 7, > }, > - # TODO: deprecrated, remove with PVE 9 > - pg_bits => { > - description => "Placement group bits, used to specify the " > - . "default number of placement groups.\n\nDepreacted. This " > - . "setting was deprecated in recent Ceph versions.", > - type => 'integer', > - default => 6, > - optional => 1, > - minimum => 6, > - maximum => 14, > - }, Any removal of an API parameters this is still a breaking API change, the chance to do that was before 9.0 release, not now. Next chance is mid next year before first public stable PVE 10.0 release. As some API integration might still send this along, and then suddenly stop working during a minor release if we push this out. The only exception here would be if passing this parameter already caused an unconditional error with the current ceph baseline version in PVE 9, which would be squid. The code below can be still dropped in any case though, making the param no-op until it's actual removal. > disable_cephx => { > description => "Disable cephx authentication.\n\n" > . "WARNING: cephx is a security feature protecting against " > @@ -238,9 +227,6 @@ __PACKAGE__->register_method({ > 'mon_allow_pool_delete' => 'true', > }; > > - # this does not work for default pools > - #'osd pool default pg num' => $pg_num, > - #'osd pool default pgp num' => $pg_num, > } > > if ($auth eq 'cephx') {