Re: [PATCH qemu-server 1/3] qemuserver: add pvpanic device

[Dominik Csapak <d.csapak@proxmox.com>]

On 9/8/26 12:09 PM, Kaiyang Wu wrote:
> On 2026-09-04 16:30, Dominik Csapak wrote:
>>> +        optional => 1,
>>> +        type => 'string',
>>> +        description => "Configure a pvpanic device to monitor guest 
>>> panics",
>>> +        enum => [qw(pvpanic pvpanic-pci)],
>>
>> is it really useful to have two variants? couldn't we always
>> use the PCI variant or is there some specific usecase for the ISA one?
>>
>> It could even be simply an option somewhere else (e.g. on the machine 
>> maybe?)
>>
>> if we just have single option, this might simplify the code below...
>>
> 
> An use case for this is deploying the ISA variant on Linux VMs with 
> kernel version >=3.1 and <5.2. The PCI variant is not supported until 
> Linux 5.2.
> 
> We could not use the ISA variant by default either, since QEMU does not 
> support ISA devices at all on ARM64.

since we didn't have any requests for this device at all, and
i hope that nobody uses a linux kernel that old often anymore for modern
vms, i guess we could get away with restricting this to the pci device.

this works everywhere, and should make the code much simpler.

If there is some request for this in the future for old kernels,
we can still add a 'type' property to it, but i'd keep
it simple right now.