From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 800361FF191
for <inbox@lore.proxmox.com>; Mon, 2 Jun 2025 16:34:28 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 7ADB536D36;
Mon, 2 Jun 2025 16:34:45 +0200 (CEST)
Date: Mon, 2 Jun 2025 16:34:42 +0200 (CEST)
From: Alexander Abraham <a.abraham@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Message-ID: <999303783.1030.1748874882155@webmail.proxmox.com>
In-Reply-To: <16d2868d-e1f9-4159-9115-0f141e48d541@proxmox.com>
References: <20250206122748.21317-1-a.abraham@proxmox.com>
<16d2868d-e1f9-4159-9115-0f141e48d541@proxmox.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev78
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.097 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-manager] fix #5076: Added a field for
OpenID audiences to the configuration UI
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Superseded by: https://lore.proxmox.com/pve-devel/20250602141458.142000-1-a.abraham@proxmox.com/T/#t
> Dominik Csapak <d.csapak@proxmox.com> hat am 17.02.2025 10:00 CET geschrieben:
>
>
> depending on what restrictions in the backend will be implemented,
> we should add the same here, so users get immediate feedback
> for wrong values
>
> aside from that LGTM
>
> On 2/6/25 13:27, Alexander Abraham wrote:
> > A field was added to the configuration prompt for
> > configuring audiences in OpenID realms.
> >
> > Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> > ---
> > www/manager6/dc/AuthEditOpenId.js | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/www/manager6/dc/AuthEditOpenId.js b/www/manager6/dc/AuthEditOpenId.js
> > index 544c0de5..7942fa58 100644
> > --- a/www/manager6/dc/AuthEditOpenId.js
> > +++ b/www/manager6/dc/AuthEditOpenId.js
> > @@ -111,6 +111,15 @@ Ext.define('PVE.panel.OpenIDInputPanel', {
> > deleteEmpty: '{!isCreate}',
> > },
> > },
> > + {
> > + xtype: 'proxmoxtextfield',
> > + name: 'aud',
> > + fieldLabel: gettext('Audiences'),
> > + submitEmpty: false,
> > + cbind: {
> > + deleteEmpty: '{!isCreate}',
> > + },
> > + },
> > ],
> >
> > initComponent: function() {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel