From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <g.goller@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A37949A242 for <pbs-devel@lists.proxmox.com>; Thu, 12 Oct 2023 13:50:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8266713154 for <pbs-devel@lists.proxmox.com>; Thu, 12 Oct 2023 13:49:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Thu, 12 Oct 2023 13:49:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 63D5D48F15 for <pbs-devel@lists.proxmox.com>; Thu, 12 Oct 2023 13:49:32 +0200 (CEST) Message-ID: <9912014b-0ad8-4cf8-9ce7-8b46a553b55b@proxmox.com> Date: Thu, 12 Oct 2023 13:49:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Dominik Csapak <d.csapak@proxmox.com>, Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> References: <20230913142045.240835-1-g.goller@proxmox.com> <bc2a187c-aa42-4fa8-967f-02b15ac23097@proxmox.com> Content-Language: en-US From: Gabriel Goller <g.goller@proxmox.com> In-Reply-To: <bc2a187c-aa42-4fa8-967f-02b15ac23097@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.344 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 12 Oct 2023 11:50:04 -0000 On 10/12/23 11:28, Dominik Csapak wrote: > On 9/13/23 16:20, Gabriel Goller wrote: >> When displaying the status of a job (sync, gc, etc..) the 'OK' >> and 'Error' text uses a padding of 10px to the left. The >> loading spinner is centered in the cell though. This doesn't >> look that good. > > this is debatable, and having the 'loading' state stand out, makes > sense imo. > No hard feelings from me either to be honest. It just doesn't look that good (imo) when having a short text and long rows (as in the new gc view). > *if* we want to change this, we either would have to adapt pve/pmg as > well, > or refactor the class into the widget-toolkit (idk if there are some > differences > across products, though it shouldn't be), because we also use that for > the task > and job status list (e.g. replication) I looked at them briefly and they have a few things in common, but imo it's not worth the hassle combining them. We wouldn't **need** this in pve/pmg but I could still submit a patch... let me know. > > [..]