From: Hannes Laimer <h.laimer@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager] ui: auto-installer: align network-tab with disks-tab
Date: Wed, 27 May 2026 09:51:59 +0200 [thread overview]
Message-ID: <98fdf0e9-afeb-4064-8b24-a78c00445a0b@proxmox.com> (raw)
In-Reply-To: <20260527074535.32634-1-h.laimer@proxmox.com>
On 2026-05-27 09:45, Hannes Laimer wrote:
> We don't show the advanced checkbox, so having the filter in the
> advanced section will always have it hidden. This prevents submitting
> cause the filter is required for static ip configurations. The disks
> form has the same scenario, "advanced filtering" required based on form
> input.
>
> Not having it in advanced also makes sense cause advanced usually
> implies optionality, which this is very much not for static, and for
> dhcp this filter is ignored by the installer.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> ui/src/remotes/auto_installer/prepared_answer_form.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/src/remotes/auto_installer/prepared_answer_form.rs b/ui/src/remotes/auto_installer/prepared_answer_form.rs
> index e6c1bd0..5897fe3 100644
> --- a/ui/src/remotes/auto_installer/prepared_answer_form.rs
> +++ b/ui/src/remotes/auto_installer/prepared_answer_form.rs
> @@ -400,8 +400,8 @@ pub fn render_network_options_form(
> .name("netif-name-pinning-enabled")
> .default(config.netif_name_pinning_enabled),
> )
> - .with_advanced_spacer()
> - .with_advanced_field(
> + .with_spacer()
> + .with_large_field(
this should just be `with_field` we only have one col in the network
tab, will send a v2, sorry for the noise
> tr!("Network Device Filters"),
> KeyValueList::new()
> .value(
next prev parent reply other threads:[~2026-05-27 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 7:45 [PATCH datacenter-manager] ui: auto-installer: align network-tab with disks-tab Hannes Laimer
2026-05-27 7:51 ` Hannes Laimer [this message]
2026-05-27 7:56 ` superseded: " Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98fdf0e9-afeb-4064-8b24-a78c00445a0b@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.