From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 819776CFD8 for <pbs-devel@lists.proxmox.com>; Wed, 31 Mar 2021 12:52:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F6A8EA12 for <pbs-devel@lists.proxmox.com>; Wed, 31 Mar 2021 12:52:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0E4BCEA05 for <pbs-devel@lists.proxmox.com>; Wed, 31 Mar 2021 12:52:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D382742F71 for <pbs-devel@lists.proxmox.com>; Wed, 31 Mar 2021 12:52:15 +0200 (CEST) Message-ID: <97b40547-a5ad-25f9-7150-7a93c28f0f73@proxmox.com> Date: Wed, 31 Mar 2021 12:52:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20210331094418.16609-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210331094418.16609-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.044 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [buildcfg.rs, rest.rs, proxmox-backup-api.rs, compression.rs, tools.rs, worker-task-abort.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/6] add compression to api/static files X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 31 Mar 2021 10:52:16 -0000 On 31.03.21 11:44, Dominik Csapak wrote: > by using the flate2 crate > > this series will also help send a simpler version of my zip deflate > encoder patch (i'll send that in the next few days) high level comment: talked with Dietmar in the morning, and we agreed to avoid a disk cache for now, the static files are seldom served so probably not worth a more complex caching system which produces disk IO - we can always add it in the future, if the on-demand approach shows problems. > > Dominik Csapak (6): > tools: add compression module > tools/compression: add DeflateEncoder and helpers > add a CACHE_DIR to the created directories on daemon startup > server/rest: add helpers for compression > server/rest: compress api calls > server/rest: compress static files > > Cargo.toml | 1 + > src/bin/proxmox-backup-api.rs | 2 +- > src/buildcfg.rs | 6 + > src/server/rest.rs | 181 ++++++++++++++++++++---- > src/server/worker_task.rs | 9 +- > src/tools.rs | 1 + > src/tools/compression.rs | 251 ++++++++++++++++++++++++++++++++++ > tests/worker-task-abort.rs | 2 +- > 8 files changed, 424 insertions(+), 29 deletions(-) > create mode 100644 src/tools/compression.rs >