all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH-SERIES storage 0/3] zfspool plugin: fix container rollback and linked clone with refquota=none
Date: Mon, 6 Jul 2026 12:22:24 +0200	[thread overview]
Message-ID: <979b55b7-e9fe-4d6f-b990-46f73d58823c@proxmox.com> (raw)
In-Reply-To: <20260706094223.54701-1-f.ebner@proxmox.com>

On 06/07/2026 11:43, Fiona Ebner wrote:
> As reported in the community forum [0], rollback of a container with a
> ZFS dataset with 'refquota=none' would fail. Similarly, cloning such a
> container would fail as well. The reason is that ZFS does not accept a
> 0 value for the refquota property, but returns 0 when queried with -p.
>
> [0]: https://forum.proxmox.com/threads/184113/
>
> pve-storage:
>
> Fiona Ebner (3):
>    zfspool plugin: fix regression for rollback with refquota=none
>    zfspool plugin: clone image: use zfs_get_properties() helper
>    zfspool plugin: clone: fix linked clone of container subvol with
>      refquota=none
>
>   src/PVE/Storage/ZFSPoolPlugin.pm | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
>
>
> Summary over all repositories:
>    1 files changed, 4 insertions(+), 5 deletions(-)
>
With this applied, rolling back to a snapshot with
pve-storage:refquota=0 now works and correctly sets refquota=none.

Tested-by: Filip Schauer <f.schauer@proxmox.com>





      parent reply	other threads:[~2026-07-06 10:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06  9:40 [PATCH-SERIES storage 0/3] zfspool plugin: fix container rollback and linked clone with refquota=none Fiona Ebner
2026-07-06  9:40 ` [PATCH storage 1/3] zfspool plugin: fix regression for rollback " Fiona Ebner
2026-07-06  9:40 ` [PATCH storage 2/3] zfspool plugin: clone image: use zfs_get_properties() helper Fiona Ebner
2026-07-06  9:40 ` [PATCH storage 3/3] zfspool plugin: clone: fix linked clone of container subvol with refquota=none Fiona Ebner
2026-07-06 10:22 ` Filip Schauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=979b55b7-e9fe-4d6f-b990-46f73d58823c@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal