From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 4940C1FF09F for ; Thu, 17 Sep 2026 15:17:21 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 003F521533; Thu, 17 Sep 2026 15:17:17 +0200 (CEST) Message-ID: <972f0af5-cab7-4e30-bbed-893f2729d4a8@proxmox.com> Date: Thu, 17 Sep 2026 15:17:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH qemu-server 0/3] fix #7801: warn about problematic VirtIO ISOs To: Nicolas Frey , pve-devel@lists.proxmox.com References: <20260915143237.1033142-1-n.frey@proxmox.com> Content-Language: en-US From: Jonas Theisen In-Reply-To: <20260915143237.1033142-1-n.frey@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789651032755 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.902 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JWUPIMYKHUCRYK7RZ2WWJFW3MWADHASH X-Message-ID-Hash: JWUPIMYKHUCRYK7RZ2WWJFW3MWADHASH X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 9/15/26 16:32, Nicolas Frey wrote: > This series fixes #7801 by implementing backend-only checks for VirtIO > ISOs with known issues. When a user starts, creates, or updates a VM, > the system scans for problematic VirtIO filenames and logs a warning in > the task log if a known issue is detected. > > This approach supersedes the earlier UI patches [0], following feedback > to implement the check in the backend. Since the backend check already > alerts users via task log warnings (an equally effective and less intrusive > solution) the separate API call and UI patches became unnecessary. > > Thanks Dominik and Maximilano for the feedback on the last revision > > [0] https://lore.proxmox.com/all/20260826074935.78437-1-n.frey@proxmox.com/ > > Tested the patches on current qemu-server v9.2.9. Works as intended. Only workflow that feels a little bit weird to me is when creating a Windows VM with an affected ISO version and using "Start after Create" This causes two directly consecutive tasks with warnings but i also do not have a better idea on how to avoid this. Tested (Web UI):  * Existing Windows VM with affected ISO => Warning  * Existing Windows VM with unaffected ISO => No Warning  * New VM with affected ISO => Warning on create and start Tested-by: Jonas Theisen