From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 996471FF185 for ; Mon, 21 Jul 2025 14:36:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 31B25E2E0; Mon, 21 Jul 2025 14:37:36 +0200 (CEST) Message-ID: <972e8d56-8f88-4cd3-9f9f-09e8dca02348@proxmox.com> Date: Mon, 21 Jul 2025 14:37:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Aaron Lauterer References: <20250715143218.1548306-1-a.lauterer@proxmox.com> <20250715143218.1548306-24-a.lauterer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250715143218.1548306-24-a.lauterer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753101445369 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v3 10/14] ui: GuestSummary: memory switch to stacked and add hostmem X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" two comments inline: On 7/15/25 16:32, Aaron Lauterer wrote: > We switch the memory graph to a stacked area graph, similar to what we > have now on the node summary page. > > Since the order is important, we need to define the colors manually, as > the default color scheme would switch the colors as we usually have > them. > > Additionally we add the host memory view as another data series. But we > keep it as a single line without fill. We chose the grey tone so that is > works for both, bright and dark theme. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/panel/GuestSummary.js | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js > index 0b62dbb7..e26b0ada 100644 > --- a/www/manager6/panel/GuestSummary.js > +++ b/www/manager6/panel/GuestSummary.js > @@ -30,6 +30,28 @@ Ext.define('PVE.guest.Summary', { > var template = !!me.pveSelNode.data.template; > var rstore = me.statusStore; > > + let memhostField = { > + type: 'line', > + fill: false, > + yField: 'memhost', > + title: gettext('Host memory usage'), > + style: { > + lineWidth: 2.5, > + opacity: 1, > + }, > + }; you could define that inline in the 'push' call below, then there is no need for the extra variable.... > + > + let memoryFields = [ > + { > + type: 'area', > + yField: ['mem', 'maxmem-capped'], > + title: [gettext('RAM usage'), gettext('Configured')],) as discussed off-list, 'configured' is not a good name, just keeping 'total' is better. > + }, > + ]; > + if (type === 'qemu') { > + memoryFields.push(memhostField); ...here, like: memoryFields.push({ type: 'line', ... }); > + } > + > var items = [ > { > xtype: template ? 'pveTemplateStatusView' : 'pveGuestStatusView', > @@ -82,8 +104,8 @@ Ext.define('PVE.guest.Summary', { > xtype: 'proxmoxRRDChart', > title: gettext('Memory usage'), > pveSelNode: me.pveSelNode, > - fields: ['maxmem', 'mem'], > - fieldTitles: [gettext('Total'), gettext('RAM usage')], > + fields: memoryFields, > + colors: ['#115fa6', '#94ae0a', '#c4c0c0'], > unit: 'bytes', > powerOfTwo: true, > store: rrdstore, _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel