From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 807F91FF191 for ; Tue, 9 Sep 2025 15:21:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9F00BA62B; Tue, 9 Sep 2025 15:21:05 +0200 (CEST) Message-ID: <954de4ff-2ddf-4004-8344-2a63cd3aeea1@proxmox.com> Date: Tue, 9 Sep 2025 15:21:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Dominik Csapak , Proxmox Datacenter Manager development discussion References: <20250909100838.234778-1-s.hanreich@proxmox.com> <20250909100838.234778-6-s.hanreich@proxmox.com> <9cfa23fc-2a8b-4cf1-9fb3-2a4135285d04@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <9cfa23fc-2a8b-4cf1-9fb3-2a4135285d04@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.715 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager 4/5] ui: images: add sdn icon X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 9/9/25 3:16 PM, Dominik Csapak wrote: > while this is good enough for now imho > > we should really think about creating our own font with the missing > icons, or think about changing to an iconset that includes the ones we > need/want. The approach here fixes the color issue, but we still > have a scaling problem, as in, the svg does not scale with the > set font-size, like the rest of the font-awesome icons. > > This is ok for the uses we have now, but might not always work out > (e.g. the font-size in panel headers is 20px for desktop and > 14px for crisp, so the 16px here sit somewhere in between, so it > does not stand out that much) Yeah, I think so as well - I stated it in the commit message for that purpose. Didn't even think of the size not applying as well tbh - that basically extends to every property that affects text I suppose (line-height comes to mind as potentially problematic as well for instance). Might want to look into that sooner rather than later... _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel