From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id C20681FF13E
	for <inbox@lore.proxmox.com>; Fri, 17 Apr 2026 10:33:56 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id E566C19BA8;
	Fri, 17 Apr 2026 10:33:55 +0200 (CEST)
Message-ID: <951b40ef-65fd-48e4-a7ef-2939ea0435dc@proxmox.com>
Date: Fri, 17 Apr 2026 10:33:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH manager 4/5] ui: cluster info: move initialization of
 items to initComponent
To: =?UTF-8?Q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com>,
 pve-devel@lists.proxmox.com
References: <20260330144321.321072-1-m.koeppl@proxmox.com>
 <20260330144321.321072-5-m.koeppl@proxmox.com>
Content-Language: en-US
From: Friedrich Weber <f.weber@proxmox.com>
In-Reply-To: <20260330144321.321072-5-m.koeppl@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1776414720141
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.013 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: LAN7AI4ITITVDRKPD3YKTIN2UQ4JDR6L
X-Message-ID-Hash: LAN7AI4ITITVDRKPD3YKTIN2UQ4JDR6L
X-MailFrom: f.weber@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On 30/03/2026 16:47, Michael Köppl wrote:
> This allows conditionally adding items to the form.
> 
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
> Preparatory patch, no functional changes intended.

The "No functional changes intended" should go into the commit message,
it's also valuable information when the patch is applied.