From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A7EF21FF183 for ; Wed, 5 Nov 2025 11:11:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EFC372019B; Wed, 5 Nov 2025 11:12:23 +0100 (CET) Message-ID: <94ab5a31-44d0-4abd-b05a-571c19641212@proxmox.com> Date: Wed, 5 Nov 2025 11:12:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Datacenter Manager development discussion , Lukas Wagner References: <20251103123521.266258-1-l.wagner@proxmox.com> <20251103123521.266258-13-l.wagner@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20251103123521.266258-13-l.wagner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762337514247 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager v2 12/12] pdm-client: top entities: add view-filter parameter X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" This'll need some changes in the gui since this moved to ui/src/dashboard/view.rs otherwise LGTM On 11/3/25 1:35 PM, Lukas Wagner wrote: > Signed-off-by: Lukas Wagner > --- > lib/pdm-client/src/lib.rs | 10 +++++++--- > ui/src/dashboard/mod.rs | 2 +- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/lib/pdm-client/src/lib.rs b/lib/pdm-client/src/lib.rs > index 7102ee05..c9ed18cc 100644 > --- a/lib/pdm-client/src/lib.rs > +++ b/lib/pdm-client/src/lib.rs > @@ -956,9 +956,13 @@ impl PdmClient { > Ok(self.0.get(&path).await?.expect_json()?.data) > } > > - pub async fn get_top_entities(&self) -> Result { > - let path = "/api2/extjs/resources/top-entities"; > - Ok(self.0.get(path).await?.expect_json()?.data) > + pub async fn get_top_entities(&self, view_filter: Option<&str>) -> Result { > + let builder = ApiPathBuilder::new("/api2/extjs/resources/top-entities".to_string()) > + .maybe_arg("view-filter", &view_filter); > + > + let path = builder.build(); > + > + Ok(self.0.get(&path).await?.expect_json()?.data) > } > > pub async fn pve_node_status(&self, remote: &str, node: &str) -> Result { > diff --git a/ui/src/dashboard/mod.rs b/ui/src/dashboard/mod.rs > index 07d5cd99..ce64d847 100644 > --- a/ui/src/dashboard/mod.rs > +++ b/ui/src/dashboard/mod.rs > @@ -319,7 +319,7 @@ impl PdmDashboard { > let top_entities_future = { > let link = link.clone(); > async move { > - let res = client.get_top_entities().await; > + let res = client.get_top_entities(None).await; > link.send_message(Msg::LoadingFinished(LoadingResult::TopEntities(res))); > } > }; _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel