all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: form/DriveSelector: do not autoselect the drive
Date: Tue, 8 Jun 2021 08:29:19 +0200	[thread overview]
Message-ID: <948e512c-b3c8-f80e-2710-c64d885f004f@proxmox.com> (raw)
In-Reply-To: <20210607130645.11838-1-d.csapak@proxmox.com>

On 07.06.21 15:06, Dominik Csapak wrote:
> in case an invalid drive was configured, now it marks the field invalid
> instead of autoselecting the first valid one
> 
> this could have lead to users configuring the wrong drive in a tape-backup-job
> when they edited one
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/tape/form/DriveSelector.js | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied this already, but it should be obsolete once we bump widget-toolkit with my
patch for combo grid, at least if that patch does not causes problems and can stay.




      parent reply	other threads:[~2021-06-08  6:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 13:06 [pbs-devel] " Dominik Csapak
2021-06-07 13:06 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/TapeBackupJob: use correct default value for pbsUserSelector Dominik Csapak
2021-06-08  6:29   ` [pbs-devel] applied: " Thomas Lamprecht
2021-06-08  6:29 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=948e512c-b3c8-f80e-2710-c64d885f004f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal