From: Fabian Ebner <f.ebner@proxmox.com>
To: Matthias Heiserer <m.heiserer@proxmox.com>,
pve-devel@lists.proxmox.com,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/5 v2] Storage GUI: Rewrite backup content view as TreePanel.
Date: Thu, 31 Mar 2022 08:36:52 +0200 [thread overview]
Message-ID: <943bba51-1bd3-263b-d8c7-1cd667d15d00@proxmox.com> (raw)
In-Reply-To: <af7dc5a9-e1b2-3cb4-ed0d-173017ad4066@proxmox.com>
Am 30.03.22 um 14:59 schrieb Matthias Heiserer:
> 8<
>
>>> + onLoad: function(store, records, success, operation) {
>>> + let me = this;
>>> + let view = me.getView();
>>> + let selection = view.getSelection()?.[0];
>>> + selection = selection?.parentNode?.data?.text
>>> +selection?.data?.volid;
>>
>> Style nit: missing space after + and could use `${...}${...}` syntax
>> instead.
> That syntax won't work because then, if both parameters are undefined,
> the result would be a string instead of a falsy (NaN) value.
> There's probably a better way of doing this.
>
Ok.
>>
>> (...)
>>
>>> + if (selection) {
>>> + let rootnode = view.getRootNode();
>>> + let selected;
>>> + rootnode.cascade(node => {
>>> + if (selected) {return false;} // skip if already found
>>
>> Style nit: if body on the same line
> Is 'if on one line' something we generally don't do? It appears
> occasionally in the code.
I don't think it's explicitly forbidden by our style guide, which
essentially is what the linter complains about, but in the (vast)
majority of cases, the body is on its own line.
>>
>>> + method: 'DELETE',
>>> + callback: () => me.reload(),
>>> + failure: response => Ext.Msg.alert(gettext('Error'),
>>> response.htmlStatus),
>>> + });
>>> + },
>>> +
>>> + searchKeyupFn: function(field) {
>>> + let me = this;
>>> + me.getView().getStore().getFilters().removeByKey('volid');
>>> + me.getView().getStore().filter([
>>> + {
>>> + property: 'volid',
>>> + value: field.getValue(),
>>> + anyMatch: true,
>>> + caseSensitive: false,
>>> + id: 'volid',
>>> },
>>> - verification: {
>>> - header: gettext('Verify State'),
>>> - dataIndex: 'verification',
>>> - renderer: PVE.Utils.render_backup_verification,
>>> + ]);
>>> + },
>>> +
>>> + searchClearHandler: function(field) {
>>> + field.triggers.clear.setVisible(false);
>>> + field.setValue(this.originalValue);
>>> + this.getView().getStore().clearFilter();
>>> + },
>>> +
>>> + searchChangeFn: function(field, newValue, oldValue) {
>>> + if (newValue !== field.originalValue) {
>>> + field.triggers.clear.setVisible(true);
>>> + }
>>> + },
>>> +
>>> + storageSelectorBoxReady: function(selector, width, height, eOpts) {
>>> + selector.setNodename(this.nodename);
>>> + },
>>
>> Would cbind also be an option?
>>
> Don't think so, as nodename comes from pveSelNode.
> However, normal bind works :)
I mean, you would need to return it as part of the cbindData() ;)
next prev parent reply other threads:[~2022-03-31 6:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 13:52 [pve-devel] [PATCH manager 0/5 v2] BackupView " Matthias Heiserer
2022-03-18 13:52 ` [pve-devel] [PATCH manager 1/5 v2] Storage GUI: Rewrite backup content view " Matthias Heiserer
2022-03-22 8:42 ` Fabian Ebner
2022-03-22 12:38 ` Thomas Lamprecht
2022-03-30 12:59 ` Matthias Heiserer
2022-03-31 6:36 ` Fabian Ebner [this message]
2022-03-31 6:56 ` Thomas Lamprecht
2022-03-18 13:52 ` [pve-devel] [PATCH manager 2/5 v2] GUI: Utils: Helpers for backup type and icon Matthias Heiserer
2022-03-18 14:51 ` Thomas Lamprecht
2022-03-18 13:52 ` [pve-devel] [PATCH manager 3/5 v2] Backup GUI: Use the new storage/BackupView instead of grid/BackupView Matthias Heiserer
2022-03-22 8:47 ` Fabian Ebner
2022-03-18 13:52 ` [pve-devel] [PATCH manager 4/5 v2] Remove grid/backupview as it got replaced by storage/backupview Matthias Heiserer
2022-03-22 8:47 ` Fabian Ebner
2022-03-18 13:52 ` [pve-devel] [PATCH manager 5/5 v2] Storage ContentView: Remove dead code Matthias Heiserer
2022-03-22 8:48 ` Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=943bba51-1bd3-263b-d8c7-1cd667d15d00@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal