Re: applied: [PATCH pve-manager v2] api: nodes: dns: restart postfix after changing name servers

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 10.11.26 um 20:16 schrieb Thomas Lamprecht:
> On Tue, 10 Nov 2026 10:31:57 +0100, Jonas Theisen wrote:
>> Postfix runs its SMTP client in a chroot and copies /etc/resolv.conf
>> into it only when the instance starts. A running postfix therefore
>> keeps using the old name servers after a DNS settings change,
>> which can make mail delivery fail until the next restart.
>>
>> Use try-restart on postfix.service after writing the new settings, so
>> postfix is only restarted if it is running.
>> A failed restart only warns, since the DNS settings were already
>> written.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] api: nodes: dns: restart postfix after changing name servers
>       https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=47df03e04a471b9041f5217dbe887d9ee890ac0b

what I forgot to mention:

I dropped the patch changelog from the commit message, that doesn't belong
in the permanent git history, it's rather relevant for development and
review of a series – else series with lots of churn and double digits would
consist mostly of changelogs from unrelated versions. If you place these in
the diff-stat section, i.e below "---" like

```
---

changes since v1:
...

 PVE/API2/Nodes.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
```

It will be visible on list but ignored by git on apply.

As I was touching this anyway I also merged "nodes dns" into one tag
(the idea is to have a rough subsystem like tag not a direct mapping
of the file or api path with s!/!:! applied) and used a Link trailer
for the forum link – again, only because I touched the commit message
anyway, else I would not had bothered, these are tiny and partially
subjective nits.