all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH common] schema: explicitly set min/max for vmid option
Date: Fri, 16 Jun 2023 10:23:07 +0200	[thread overview]
Message-ID: <93b45eda-a000-709e-05b9-5a32dacac5fd@proxmox.com> (raw)
In-Reply-To: <20230616073537.17526-1-f.ebner@proxmox.com>

Am 16/06/2023 um 09:35 schrieb Fiona Ebner:
> The associated pve_verify_vmid() method already restricts the value
> to this range, but this wouldn't be visible in the API viewer for
> example [0].
> 
> The verify method is also called by qemu-server's qmextract, so it's
> not possible to just drop the method right now.
> 
> [0]: https://forum.proxmox.com/threads/128845/post-564526
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/JSONSchema.pm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
>

applied, thanks!

let's see if we ever used values < 100 as some special thingy somwhere ;-P
(if, those things should probably just switch to another format)




  reply	other threads:[~2023-06-16  8:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  7:35 [pve-devel] " Fiona Ebner
2023-06-16  8:23 ` Thomas Lamprecht [this message]
2023-06-16  9:01   ` [pve-devel] applied: " Fiona Ebner
2023-06-16 10:40     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93b45eda-a000-709e-05b9-5a32dacac5fd@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal