From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 77FC27513C
 for <pve-devel@lists.proxmox.com>; Tue, 12 Oct 2021 17:24:42 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 622BC2F083
 for <pve-devel@lists.proxmox.com>; Tue, 12 Oct 2021 17:24:12 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 43F072F073
 for <pve-devel@lists.proxmox.com>; Tue, 12 Oct 2021 17:24:11 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1898C45D7E
 for <pve-devel@lists.proxmox.com>; Tue, 12 Oct 2021 17:24:11 +0200 (CEST)
Message-ID: <9325c82b-3e99-d91e-b1e6-3ddf8a396df9@proxmox.com>
Date: Tue, 12 Oct 2021 17:24:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101
 Thunderbird/94.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Aaron Lauterer <a.lauterer@proxmox.com>, Stefan Reiter <s.reiter@proxmox.com>
References: <20211011125520.1124937-1-s.reiter@proxmox.com>
 <54905ea8-87f9-6cdb-17c1-de312aece9ec@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <54905ea8-87f9-6cdb-17c1-de312aece9ec@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.206 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH 0/3] Windows 11 OS type and UI improvements
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 12 Oct 2021 15:24:42 -0000

On 12.10.21 15:51, Aaron Lauterer wrote:
> Works. As discussed off list, we should make it clearer in the "System"
> panel, that the TPM and EFI disk settings (Storage selection and such) belong
> to those "Checkboxes". While it is somewhat clear if enabled manually, it is
> quite confusing with them already enabled because one chose Win11 as guest OS
> in the previous step.

as dicussed off-list, I'd just extend the field labels for the respective storage selector.

- "EFIvars Storage"
- "TPM Storage"

> Additionally, setting the RAM to a default of 4096 for Win11 guests might be
> a good idea, as the Win11 installer will refuse to install because the
> requirements are not met if there is not enough RAM. A too small disk
> (<52GiB) will cause a warning in the Disk selection dialog of the installer,
> but it will still install.

Yes, thought about that too when running into the very dubious and unhelpful
"your system does not fulfill the min reqs. but we won't tell you why" the
first time.
With the new OS type we can default to 4 GiB memory and 64 GiB root disk for
win11 in addtion to the defaults changed here.

> 
> Besides that:
> 
> Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
> 

thanks, those tags are always valuable!