From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 40A961FF0E7 for ; Wed, 12 Aug 2026 11:00:11 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 098872159A; Wed, 12 Aug 2026 11:00:11 +0200 (CEST) Message-ID: <92d42b4f-debe-4ec8-968f-04d695edf066@proxmox.com> Date: Wed, 12 Aug 2026 11:00:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH docs 1/3] close #7204: storage: lvm thin: document that thin pools must have zeroing enabled To: Maximiliano Sandoval References: <20260205163819.219322-1-f.ebner@proxmox.com> <20260205163819.219322-2-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786525190593 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.913 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MFX257ZCWLVRHBXX5WBVJBX5EGPFWXVB X-Message-ID-Hash: MFX257ZCWLVRHBXX5WBVJBX5EGPFWXVB X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 12.08.26 um 10:45 AM schrieb Maximiliano Sandoval: > Fiona Ebner writes: > >> Signed-off-by: Fiona Ebner >> --- >> pve-storage-lvmthin.adoc | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/pve-storage-lvmthin.adoc b/pve-storage-lvmthin.adoc >> index 83f65a3..48505a9 100644 >> --- a/pve-storage-lvmthin.adoc >> +++ b/pve-storage-lvmthin.adoc >> @@ -23,6 +23,11 @@ lvcreate -L 100G -n data pve >> lvconvert --type thin-pool pve/data >> ---- >> >> +WARNING: The `zero` property for the thin pool must be set or certain operations >> +for VM images may lead to data corruption! The property is controlled via the >> +`allocation/thin_pool_zero` LVM configuration option and is enabled by default. >> +Check with `lvs pve/data -o lv_name,zero` which should indicate `zero` in the > > The check here should be generic. Users of the default lvthin setup > (pve/data) are likely to also have the default zero=zero option set. > Perhaps something like: > > $ lvs -S 'lv_attr =~ ^t' -o lv_name,zero > LV Zero > data zero > The example above uses pve/data as the thin pool name, so I am just continuing the example. But yeah, I'll change the check in v2. >> +output below the `Zero` heading. >> >> Configuration >> ~~~~~~~~~~~~~ >