From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id ED69F1FF138 for ; Wed, 04 Feb 2026 10:56:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 386D0EF4E; Wed, 4 Feb 2026 10:57:20 +0100 (CET) Message-ID: <92a7deea-15fc-42a4-85f4-17c7fef81548@proxmox.com> Date: Wed, 4 Feb 2026 10:57:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control To: Maximiliano Sandoval , pdm-devel@lists.proxmox.com References: <20260202134926.403503-1-m.sandoval@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260202134926.403503-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770198961116 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GCVF4A4XQ6PPYL4WQQ6YO4TXP7PCRN5B X-Message-ID-Hash: GCVF4A4XQ6PPYL4WQQ6YO4TXP7PCRN5B X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 02.02.26 um 14:48 schrieb Maximiliano Sandoval: > To match the changes made in > https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=47defa79bd10991d28757a690f7dc283805b2768. > > This fixes the following error while running `cargo build`: > > ``` > $ cargo build > Compiling pdm-api-types v1.0.0 (/home/msandoval/Projects/proxmox-datacenter-manager/lib/pdm-api-types) > error[E0433]: failed to resolve: could not find `init` in `proxmox_access_control` > --> lib/pdm-api-types/src/acl.rs:192:30 > | > 192 | impl proxmox_access_control::init::AccessControlConfig for AccessControlConfig { > | ^^^^ could not find `init` in `proxmox_access_control` > | > note: found an item that was configured out > --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:12:9 > | > 11 | #[cfg(feature = "acl")] > | --------------- the item is gated behind the `acl` feature > 12 | pub mod init; > | ^^^^ > > error[E0433]: failed to resolve: could not find `acl` in `proxmox_access_control` > --> lib/pdm-api-types/src/acl.rs:257:50 > | > 257 | let components = proxmox_access_control::acl::split_acl_path(path); > | ^^^ could not find `acl` in `proxmox_access_control` > | > note: found an item that was configured out > --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:6:9 > | > 5 | #[cfg(feature = "acl")] > | --------------- the item is gated behind the `acl` feature > 6 | pub mod acl; > | ^^^ > > For more information about this error, try `rustc --explain E0433`. > error: could not compile `pdm-api-types` (lib) due to 2 previous errors > ``` This is just not a good commit message, how is having the whole compiler output helpful as rationale? One either has to follow the link or interpret a whole lot of verbose info, as the compiler cannot be sure about what the actual fix is, that could have been rather stated explicitly: proxmox-access-control gained an `acl` feature [0] to provide more granular access to the ACLTree and related types, which we now need to opt-into here" [0]: https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=47defa79bd10991d28757a690f7dc283805b2768. @Lukas: please keep commit hygiene in mind, such things can also be fixed up on applying, depending on the changes needed. > > Signed-off-by: Maximiliano Sandoval > --- > lib/pdm-api-types/Cargo.toml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/pdm-api-types/Cargo.toml b/lib/pdm-api-types/Cargo.toml > index d6429e6a..7aa7b64e 100644 > --- a/lib/pdm-api-types/Cargo.toml > +++ b/lib/pdm-api-types/Cargo.toml > @@ -14,7 +14,7 @@ serde.workspace = true > serde_plain.workspace = true > > proxmox-acme-api.workspace = true > -proxmox-access-control.workspace = true > +proxmox-access-control = { workspace = true, features = ["acl"] } > proxmox-auth-api = { workspace = true, features = ["api-types"] } > proxmox-apt-api-types.workspace = true > proxmox-lang.workspace = true