From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dietmar@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id E2C0673ED6
for <pbs-devel@lists.proxmox.com>; Mon, 31 May 2021 12:34:45 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C9ACC1D47F
for <pbs-devel@lists.proxmox.com>; Mon, 31 May 2021 12:34:15 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id B8CB81D470
for <pbs-devel@lists.proxmox.com>; Mon, 31 May 2021 12:34:14 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 88356437A3
for <pbs-devel@lists.proxmox.com>; Mon, 31 May 2021 12:34:14 +0200 (CEST)
Date: Mon, 31 May 2021 12:33:32 +0200 (CEST)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <912020634.2978.1622457212122@webmail.proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.5-Rev11
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.208 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] applied: [PATCH proxmox-backup] lto/sg_tape/encryption:
remove non lto-4 supported byte
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 31 May 2021 10:34:45 -0000
applied
> On 05/31/2021 10:29 AM Dominik Csapak <d.csapak@proxmox.com> wrote:
>
>
> from the SspDataEncryptionCapabilityPage
>
> it seems we do not need it, since the EXTDECC flag is only used for
> determining if the drive is capable to be configured via
> ADI (Automation/Drive Interface) which we do not use at all.
>
> this makes the call work with LTO-4 again
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/tape/drive/lto/sg_tape/encryption.rs | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/src/tape/drive/lto/sg_tape/encryption.rs b/src/tape/drive/lto/sg_tape/encryption.rs
> index 7b687f2c..5ce571e4 100644
> --- a/src/tape/drive/lto/sg_tape/encryption.rs
> +++ b/src/tape/drive/lto/sg_tape/encryption.rs
> @@ -195,8 +195,7 @@ struct DataEncryptionStatus {
> struct SspDataEncryptionCapabilityPage {
> page_code: u16,
> page_len: u16,
> - extdecc_cfgp_byte: u8,
> - reserved: [u8; 15],
> + reserved: [u8; 16],
> }
>
> #[derive(Endian)]
> @@ -222,17 +221,7 @@ fn decode_spin_data_encryption_caps(data: &[u8]) -> Result<u8, Error> {
>
> proxmox::try_block!({
> let mut reader = &data[..];
> - let page: SspDataEncryptionCapabilityPage = unsafe { reader.read_be_value()? };
> -
> - let extdecc = (page.extdecc_cfgp_byte & 0b00001100) >> 2;
> - if extdecc != 2 {
> - bail!("not external data encryption control capable");
> - }
> -
> - let cfg_p = page.extdecc_cfgp_byte & 0b00000011;
> - if cfg_p != 1 {
> - bail!("not allow to change logical block encryption parameters");
> - }
> + let _page: SspDataEncryptionCapabilityPage = unsafe { reader.read_be_value()? };
>
> let mut aes_cgm_index = None;
>
> --
> 2.20.1
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel