From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9C8E61FF136 for ; Mon, 20 Apr 2026 08:54:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7C91E1DC7E; Mon, 20 Apr 2026 08:54:14 +0200 (CEST) Message-ID: <90b72e07-fd9c-441e-9f27-677723ee3583@proxmox.com> Date: Mon, 20 Apr 2026 08:53:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup 0/2] fixes #7465: add gc-on-unmount flag To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260417112755.136134-1-h.laimer@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776667934114 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FX3EJR272N4KE5F4JLQRYVGJ65COQA23 X-Message-ID-Hash: FX3EJR272N4KE5F4JLQRYVGJ65COQA23 X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-04-17 16:55, Christian Ebner wrote: > On 4/17/26 1:26 PM, Hannes Laimer wrote: >> So GC can run before unmount, without this its somewhat complicated to >> run gc on a datastore that is configured to auto unmount after jobs >> finish. >> >> >> Hannes Laimer (2): >>    api: datastore: add option to run garbage collection before unmount >>    ui: datastore: expose gc-on-unmount setting >> >>   src/api2/admin/datastore.rs  | 33 +++++++++++++++++++++++++++------ >>   src/api2/config/datastore.rs |  9 +++++++++ >>   www/datastore/OptionView.js  | 23 +++++++++++++++++++++++ >>   3 files changed, 59 insertions(+), 6 deletions(-) >> > > > Looks good apart from a few smaller comments and questions. > > I'm missing the patch for pbs-api-types though? (Adapted myself for > review since it is a trivial adaption). ohh, yes, there should be one :) will include in v2 + address your comments. Thanks for taking a look!