From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7A6521FF183 for ; Wed, 24 Sep 2025 12:25:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 639F0220E; Wed, 24 Sep 2025 12:25:44 +0200 (CEST) Message-ID: <90ac517a-0426-4b32-ac24-7c61feecf8f0@proxmox.com> Date: Wed, 24 Sep 2025 12:25:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20250912161121.229819-1-s.hanreich@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20250912161121.229819-1-s.hanreich@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.716 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [firewall.rs, rule.rs, object.rs, common.rs, alias.rs, ipset.rs, guest.rs, config.rs, cluster.rs] Subject: Re: [pve-devel] [PATCH proxmox{-ve-rs, -firewall} 0/3] Add support for legacy ipset / alias names X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" found an issue while re-visiting this again in the context of creating another patch series - please do not apply for now! On 9/12/25 6:11 PM, Stefan Hanreich wrote: > The introduction of scopes to alias / ipset names in firewall rules in Proxmox > VE 8 did not include any automated mechanism for converting firewall rules. Many > users still have firewall configurations containing unscoped names. The initial > decision to only support the new format with proxmox-firewall led to problems > with users trying to migrate to the nftables firewall, since the daemon fails to > parse the configuration and generates no nftables ruleset at all. > > proxmox-ve-rs: > > Stefan Hanreich (2): > config: firewall: add support for legacy alias names > config: firewall: add support for legacy ipset names > > proxmox-ve-config/src/firewall/cluster.rs | 16 ++- > proxmox-ve-config/src/firewall/common.rs | 4 + > proxmox-ve-config/src/firewall/guest.rs | 10 +- > proxmox-ve-config/src/firewall/types/alias.rs | 98 ++++++++++++++++- > proxmox-ve-config/src/firewall/types/ipset.rs | 104 +++++++++++++++++- > proxmox-ve-config/src/firewall/types/rule.rs | 14 ++- > .../src/firewall/types/rule_match.rs | 14 +-- > 7 files changed, 232 insertions(+), 28 deletions(-) > > > proxmox-firewall: > > Stefan Hanreich (1): > fix #6107: add support for legacy ipset / alias names > > proxmox-firewall/src/config.rs | 93 ++++++++-- > proxmox-firewall/src/firewall.rs | 15 +- > proxmox-firewall/src/object.rs | 4 +- > proxmox-firewall/src/rule.rs | 28 ++- > proxmox-firewall/tests/input/cluster.fw | 2 + > .../integration_tests__firewall.snap | 172 ++++++++++++++++++ > 6 files changed, 276 insertions(+), 38 deletions(-) > > > Summary over all repositories: > 13 files changed, 508 insertions(+), 66 deletions(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel