From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 80C881FF15C for ; Fri, 14 Nov 2025 12:38:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BDC9310619; Fri, 14 Nov 2025 12:39:26 +0100 (CET) Message-ID: <909bdad0-4b8d-4453-8d42-43a16160d074@proxmox.com> Date: Fri, 14 Nov 2025 12:38:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Maximiliano Sandoval , Christoph Heiss References: <20251014132207.1171073-1-c.heiss@proxmox.com> <20251014132207.1171073-15-c.heiss@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763120307658 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer 14/14] gui: add support for pinning network interface names X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 14.10.25 um 17:03 schrieb Maximiliano Sandoval: >> + $dialog->show(); >> + $dialog->run(); > There are two ways to present dialogs, either by running > `gtk_dialog_run` which will block until the dialog is done and will > return the response (deprecated) and then close/destroy the dialog, or > connect to the response signal which will be emitted once there is a > response and the dialog can be closed (as done above) but instead of > calling `gtk_dialog_run()` one would call `gtk_window_present()` on it. > So please run `present` instead of `run` here. > > In general `present()` and `gtk_widget_show()` are kinda similar but the > former is a wrapper around the later (among other things) and is > preferable (might have a different effect depending on the compositor). > > Incidentally using gtk_widget_show() for the purpose of displaying a > window/dialog is deprecated in GTK 4. Had to switch this back to run() to make the dialog window actually modal, i.e., block interaction with the main installer window, as otherwise one could open this multiple times, or do other odd stuff like aborting the installation which then was blocked. I'm fine with using something else, but it needs to be an actual dialogue that masks the background, or we explicitly make that inactive, and for now ->run() does the job well with (currently) no downside FWICT. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel