From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 888E91FF16F for ; Tue, 2 Sep 2025 11:31:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B183E074; Tue, 2 Sep 2025 11:31:31 +0200 (CEST) Message-ID: <907667a5-aae1-4c50-b1cb-5b2373c56447@proxmox.com> Date: Tue, 2 Sep 2025 11:30:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta From: Dominik Csapak To: Stefan Hanreich , Proxmox Datacenter Manager development discussion References: <20250829145313.329114-1-s.hanreich@proxmox.com> <20250829145313.329114-30-s.hanreich@proxmox.com> <57b9ed69-c0d4-420b-8669-2e9e3b603151@proxmox.com> <4aa5b76a-a070-4658-b594-e5ec61ee0f62@proxmox.com> Content-Language: en-US In-Reply-To: <4aa5b76a-a070-4658-b594-e5ec61ee0f62@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756805444374 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager v2 14/15] ui: sdn: add evpn overview panel X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" On 9/2/25 8:34 AM, Dominik Csapak wrote: > > > On 9/1/25 5:02 PM, Stefan Hanreich wrote: >> On 9/1/25 3:44 PM, Dominik Csapak wrote: >>> one question: couldn't have the toolbar stayed the same as before? >>> >>> as in, create the toolbar in line in the `main_view` and just `clone()` >>> it once for each panel? >>> >>> not that i'm totally against factoring such things out, but the >>> `EvpnToolbar` does not do anything special FWICT, so creating >>> the toolbar inline would have been fine... >> >> I had that initially, but cloning the toolbar had issues with the >> positioning of the dropdown (it was stuck to the top left of the >> screen). Not cloning the toolbar but creating it twice fixed it for me. >> > > this sounds like a bug we should fix ;) > > i'll see how that happens and see if i can send a fix for that. > > for the time being we can ofc leave it as is and clean up when we have a > fix > > for the record for the list: the issue here was that every component in our toolkit has a 'NodeRef' (in their std_props) that is linked to a Dom element on rendering In the MenuButton we use this NodeRef from the std_props as the anchor for aligning the menu. When we clone some component's properties, we clone the NodeRef too but that messes up the references to the dom, since now the clone points to the same noderef The first rendered menu works fine, but when the second one is rendered the link from noderef <-> dom changes to the second one. Now when one is trying to use the menu on the first tab, the noderef points to an element which is invisible, which fails to align properly. We're still deciding how to cope with cloning properties and their node_refs (we could make it optional, make sure aligning always require internal node_refs, impl clone such that the nodref is not copied, etc) the easiest fix here is to simply have a fn create_toolbar(...) -> Toolbar function that returns a new toolbar each time and use that twice. This is still much shorter than having a full component for basically the `view` method. Can be cleaned up as a follow-up IMO _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel