From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id D86F1641C1
for <pbs-devel@lists.proxmox.com>; Thu, 29 Oct 2020 17:11:28 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id C7701B0DD
for <pbs-devel@lists.proxmox.com>; Thu, 29 Oct 2020 17:11:28 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id A6315B0D0
for <pbs-devel@lists.proxmox.com>; Thu, 29 Oct 2020 17:11:27 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 68DC445F98
for <pbs-devel@lists.proxmox.com>; Thu, 29 Oct 2020 17:11:27 +0100 (CET)
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com>
References: <20201028131206.23593-1-f.ebner@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <8e8ff26a-0750-463b-149f-e7014ccf170c@proxmox.com>
Date: Thu, 29 Oct 2020 17:11:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101
Thunderbird/83.0
MIME-Version: 1.0
In-Reply-To: <20201028131206.23593-1-f.ebner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.065 Adjusted score from AWL reputation of From: address
KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.921 Looks like a legit reply (A)
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [RFC v2 proxmox-backup] create prune simulator
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 29 Oct 2020 16:11:28 -0000
On 28.10.20 14:12, Fabian Ebner wrote:
> A stand-alone ExtJS app that allows experimenting with
> different backup schedules and prune parameters.
>=20
> For performance reasons, the week table does not use
> subcomponents, but raw HTML.
>=20
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>=20
> Changes from v1:
> * add list view of backups as we have in PBS
> * make it possible to toggle the calendar and hide it by default
> * make it possible to toggle the colors and turn them off by defaul=
t
> * fix backup sorting and uniqueness when there is more than one sta=
rt time
> * add a button for applying a new schedule instead of doing so cont=
inuosly
> * make it more obvious that one can input a custom schedule
> * error out on invalid schedule inputs
> * make the number of weeks configurable
> * show which rule keeps a specific backup
> * keep all if all options are zero
> * minor style improvements
>=20
I find it pretty nice now, great job!
I'd only reorder it a bit, make it a full-page application and add some p=
rune/schedule
documentation - we could maybe just pull that 1:1 from the docs html outp=
ut or
something, it hasn't to be extra long just a short widget explanation and=
some other
info which would assist users to understand the concepts and plan their s=
chedule
interactively.
I.e., something like the following layout:
+--------------------------------------------------+---------------------=
-----+
| | =
|
| Simulated | =
|
| Backup Schedule | Documentation =
|
| | =
|
+-------------------------+------------------------+ * What this widget =
is |
| | | =
|
| Prune keep settings | Prune "keep" view | * prune params expl=
ained|
| | | =
|
| | | * ... =
|
| | | =
|
| | | =
|
+-------------------------+------------------------+ =
|
| | =
|
| | =
|
| | =
|
| | =
|
| | =
|
| | =
|
| | =
|
| Calendar | =
|
| | =
|
| | =
|
| | =
|
| | =
|
| | =
|
| | =
|
| | =
|
| | =
|
+--------------------------------------------------+---------------------=
-----+
But in any way, I like it a lot more than v1, and that wasn't bad either =
:)