From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0B6FB1FF16F for ; Tue, 5 Aug 2025 10:56:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1FB59FA7; Tue, 5 Aug 2025 10:58:14 +0200 (CEST) Message-ID: <8cad4191-6b96-49cb-9cd8-579b28607d3d@proxmox.com> Date: Tue, 5 Aug 2025 10:57:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Stefan Hanreich References: <20250805082926.48280-1-s.hanreich@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20250805082926.48280-1-s.hanreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754384241119 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH manager/network 0/2] Improve FRR reloading logic X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 05/08/2025 10:29, Stefan Hanreich wrote: > Follow-up to the stop gap fix in [1]. > > This should handle all cases that we need to consider: > > * Do not overwrite existing FRR configurations, unless we need to generate our > own FRR configuration. > > * Do not trigger a FRR enable when reloading the host configuration, even though > there is no FRR configuration. > > * Overwrite the FRR configuration with an empty configuration if all SDN > entities using FRR got deleted. > > * Regenerate the FRR configuration when the host network configuration changes, > since this might affect the generated FRR configuration. > > > [1] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=6c5295a1cdb6ec872ddf997cae030817dffff106 Thanks for the patch! Installed on my host that doesn't use fabrics (frr is disabled and not running), and when applying the network configuration, frr is not enabled. When applying my SDN configuration (that only uses Simple Zones, no fabrics), frr is not enabled either. I haven't tested on a setup *with* fabrics, though. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel